Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyslurm: 20170302 -> 20180427 #39694

Merged
merged 1 commit into from May 2, 2018
Merged

pythonPackages.pyslurm: 20170302 -> 20180427 #39694

merged 1 commit into from May 2, 2018

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Apr 30, 2018

Fixes build against slurm 17.11.5

Fixes: 0e0b80d ('slurm: 17.11.3 -> 17.11.5')

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@veprbl veprbl requested a review from FRidh as a code owner April 30, 2018 00:24
@veprbl
Copy link
Member Author

veprbl commented Apr 30, 2018

@GrahamcOfBorg build python2Packages.pyslurm python3Packages.pyslurm

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: python2Packages.pyslurm, python3Packages.pyslurm

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2Packages.pyslurm, python3Packages.pyslurm

Partial log (click to expand)


OK
gcc -pthread -shared -lgcc_s build/temp.linux-x86_64-2.7/pyslurm/pyslurm.o -L -L/slurm -L/nix/store/l9j2jsc9flrbmpf799nw9wdq59gpwms8-python-2.7.14/lib -Wl,-R/ -Wl,-R/slurm -lslurmdb -lslurm -lpython2.7 -o /build/source/pyslurm/pyslurm.so

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/xp3mi1pxni065gzzj0wvwzfnz9a0rykl-python2.7-pyslurm-20180427
/nix/store/k6rzjnccskm8xi5v2khdh90lpkvgk7qq-python3.6-pyslurm-20180427

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python2Packages.pyslurm, python3Packages.pyslurm

Partial log (click to expand)

/nix/store/9ib9731m2av0dxpnj36gdwr48c6qmzvd-python2.7-numpy-1.14.2/lib/python2.7/site-packages/numpy/core/include/numpy/npy_1_7_deprecated_api.h:15:2: warning: #warning "Using deprecated NumPy API, disable it by " "#defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-Wcpp]
 #warning "Using deprecated NumPy API, disable it by " \
  ^~~~~~~
acquired default
acquired Global_A
building of '/nix/store/kh3qnjl7ik5ap4awv41hx6inl5k390sj-python2.7-Cython-0.28.1.drv' timed out after 3600 seconds
building of '/nix/store/dqfscwhjqfxd73arwp1gxf1y2wh0k6dm-python3.6-Cython-0.28.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/cvjl5qgsbayd999zx3qr2rnhmwqj122p-python2.7-pyslurm-20180427.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/mz1w149idyg0yx35p7zif635rmxq8qsh-python3.6-pyslurm-20180427.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/cvjl5qgsbayd999zx3qr2rnhmwqj122p-python2.7-pyslurm-20180427.drv', '/nix/store/mz1w149idyg0yx35p7zif635rmxq8qsh-python3.6-pyslurm-20180427.drv' failed

dotlambda
dotlambda requested changes Apr 30, 2018
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please prefix the commit message with pythonPackages.

@veprbl
pythonPackages.pyslurm: 20170302 -> 20180427
bb12277 
Fixes build against slurm 17.11.5

Fixes: 0e0b80d ('slurm: 17.11.3 -> 17.11.5')
@veprbl veprbl force-pushed the pr/pyslurm_fix_for_17.11.5 branch from 66090a5 to bb12277 Compare April 30, 2018 15:29
@veprbl veprbl changed the title pyslurm: 20170302 -> 20180427 pythonPackages.pyslurm: 20170302 -> 20180427 Apr 30, 2018
@dotlambda dotlambda merged commit ac75ebf into NixOS:master May 2, 2018
@veprbl veprbl deleted the pr/pyslurm_fix_for_17.11.5 branch December 1, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @GrahamcOfBorg @dotlambda