Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

franz, maxx: switch to autoPatchelfHook #40703

Merged
merged 2 commits into from May 18, 2018
Merged

franz, maxx: switch to autoPatchelfHook #40703

merged 2 commits into from May 18, 2018

Conversation

ghost
Copy link

@ghost ghost commented May 17, 2018 •
edited by ghost

Motivation for this change

Make proprietary packages I maintain use autoPatchelfHook

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [ x Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented May 18, 2018

@GrahamcOfBorg build franz

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: franz

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: franz

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: franz

Partial log (click to expand)

searching for dependencies of /nix/store/bdxcjbbisqsx1zkqw5w2xzwx3sx1d2ph-franz-4.0.4/opt/franz/libffmpeg.so
searching for dependencies of /nix/store/bdxcjbbisqsx1zkqw5w2xzwx3sx1d2ph-franz-4.0.4/opt/franz/libnode.so
  libstdc++.so.6 -> found: /nix/store/vz5q4hi1rdc91llnrrd5dfvqw3xn4sgw-gcc-7.3.0-lib/lib/libstdc++.so.6
setting RPATH to: /nix/store/vz5q4hi1rdc91llnrrd5dfvqw3xn4sgw-gcc-7.3.0-lib/lib
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bdxcjbbisqsx1zkqw5w2xzwx3sx1d2ph-franz-4.0.4/bin
patching script interpreter paths in /nix/store/bdxcjbbisqsx1zkqw5w2xzwx3sx1d2ph-franz-4.0.4
checking for references to /build in /nix/store/bdxcjbbisqsx1zkqw5w2xzwx3sx1d2ph-franz-4.0.4...
file /nix/store/bdxcjbbisqsx1zkqw5w2xzwx3sx1d2ph-franz-4.0.4/opt/franz/Franz had a PT_GNU_STACK program header, converted
/nix/store/bdxcjbbisqsx1zkqw5w2xzwx3sx1d2ph-franz-4.0.4

@xeji xeji merged commit cfc016c into NixOS:master May 18, 2018
@ghost
Copy link
Author

ghost commented May 19, 2018

@xeji Thank you!

@ghost ghost deleted the autopatchelf branch May 19, 2018 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xeji @GrahamcOfBorg