Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

form: init at 4.2.0 #40693

Merged
merged 1 commit into from May 22, 2018
Merged

form: init at 4.2.0 #40693

merged 1 commit into from May 22, 2018

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented May 17, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: form

Partial log (click to expand)

/nix/store/wa2alv4iiwzmv7sdn5gjnl6bvnv9ls5h-form-4.2.0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wa2alv4iiwzmv7sdn5gjnl6bvnv9ls5h-form-4.2.0
shrinking /nix/store/wa2alv4iiwzmv7sdn5gjnl6bvnv9ls5h-form-4.2.0/bin/form
shrinking /nix/store/wa2alv4iiwzmv7sdn5gjnl6bvnv9ls5h-form-4.2.0/bin/tform
gzipping man pages under /nix/store/wa2alv4iiwzmv7sdn5gjnl6bvnv9ls5h-form-4.2.0/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wa2alv4iiwzmv7sdn5gjnl6bvnv9ls5h-form-4.2.0/bin
patching script interpreter paths in /nix/store/wa2alv4iiwzmv7sdn5gjnl6bvnv9ls5h-form-4.2.0
checking for references to /build in /nix/store/wa2alv4iiwzmv7sdn5gjnl6bvnv9ls5h-form-4.2.0...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: form

Partial log (click to expand)

make[2]: Nothing to be done for 'install-exec-am'.
make[2]: Nothing to be done for 'install-data-am'.
make[2]: Leaving directory '/private/tmp/nix-build-form-4.2.0.drv-0/form-4.2.0'
make[1]: Leaving directory '/private/tmp/nix-build-form-4.2.0.drv-0/form-4.2.0'
post-installation fixup
gzipping man pages under /nix/store/v9702p13y07nlbszb0ggw33wpdgpwc3z-form-4.2.0/share/man/
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/v9702p13y07nlbszb0ggw33wpdgpwc3z-form-4.2.0/bin
patching script interpreter paths in /nix/store/v9702p13y07nlbszb0ggw33wpdgpwc3z-form-4.2.0
/nix/store/v9702p13y07nlbszb0ggw33wpdgpwc3z-form-4.2.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: form

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rzivjriv8igvwirbgn6mm73ys3i91a9h-form-4.2.0
shrinking /nix/store/rzivjriv8igvwirbgn6mm73ys3i91a9h-form-4.2.0/bin/tform
shrinking /nix/store/rzivjriv8igvwirbgn6mm73ys3i91a9h-form-4.2.0/bin/form
gzipping man pages under /nix/store/rzivjriv8igvwirbgn6mm73ys3i91a9h-form-4.2.0/share/man/
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rzivjriv8igvwirbgn6mm73ys3i91a9h-form-4.2.0/bin
patching script interpreter paths in /nix/store/rzivjriv8igvwirbgn6mm73ys3i91a9h-form-4.2.0
checking for references to /build in /nix/store/rzivjriv8igvwirbgn6mm73ys3i91a9h-form-4.2.0...
/nix/store/rzivjriv8igvwirbgn6mm73ys3i91a9h-form-4.2.0

xeji
xeji reviewed May 22, 2018
View reviewed changes
pkgs/applications/science/math/form/default.nix Outdated
@@ -0,0 +1,19 @@
{ stdenv, fetchurl }:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you consider this upstream recommendation?

Before building FORM, it is advised to install the optional dependencies gmp and zlib for better performance.

pkgs/applications/science/math/form/default.nix Outdated
sha256 = "19528aphn4hvm151lyyhd7wz0bp2s3rla8jv6s7d8jwfp5ljzysm";
};

meta = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you write meta = with stdenv.lib; { here you don't need to repeat this 3 times below.

pkgs/applications/science/math/form/default.nix Outdated
version = "4.2.0";
name = "form-${version}";

src = fetchurl {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In nixpkgs we generally prefer fetchFromGitHub for github sources.

@veprbl
Copy link
Member Author

veprbl commented May 22, 2018

@xeji
Thank you for your comments. I updated the expression.

xeji
xeji reviewed May 22, 2018
View reviewed changes
pkgs/applications/science/math/form/default.nix Outdated
homepage = https://www.nikhef.nl/~form/;
license = licenses.gpl3;
maintainers = [ maintainers.veprbl ];
platforms = lib.platforms.unix;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't build because of the lib left over here.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: form

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1dn5mlrblry3aq6x7nf9mynrlnxzlvya-form-4.2.0
shrinking /nix/store/1dn5mlrblry3aq6x7nf9mynrlnxzlvya-form-4.2.0/bin/tform
shrinking /nix/store/1dn5mlrblry3aq6x7nf9mynrlnxzlvya-form-4.2.0/bin/form
gzipping man pages under /nix/store/1dn5mlrblry3aq6x7nf9mynrlnxzlvya-form-4.2.0/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1dn5mlrblry3aq6x7nf9mynrlnxzlvya-form-4.2.0/bin
patching script interpreter paths in /nix/store/1dn5mlrblry3aq6x7nf9mynrlnxzlvya-form-4.2.0
checking for references to /build in /nix/store/1dn5mlrblry3aq6x7nf9mynrlnxzlvya-form-4.2.0...
/nix/store/1dn5mlrblry3aq6x7nf9mynrlnxzlvya-form-4.2.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: form

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1gcb91b4cy42s3cam19bn7a430lwhwsh-form-4.2.0
shrinking /nix/store/1gcb91b4cy42s3cam19bn7a430lwhwsh-form-4.2.0/bin/tform
shrinking /nix/store/1gcb91b4cy42s3cam19bn7a430lwhwsh-form-4.2.0/bin/form
gzipping man pages under /nix/store/1gcb91b4cy42s3cam19bn7a430lwhwsh-form-4.2.0/share/man/
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1gcb91b4cy42s3cam19bn7a430lwhwsh-form-4.2.0/bin
patching script interpreter paths in /nix/store/1gcb91b4cy42s3cam19bn7a430lwhwsh-form-4.2.0
checking for references to /build in /nix/store/1gcb91b4cy42s3cam19bn7a430lwhwsh-form-4.2.0...
/nix/store/1gcb91b4cy42s3cam19bn7a430lwhwsh-form-4.2.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: form

Partial log (click to expand)

make[2]: Nothing to be done for 'install-exec-am'.
make[2]: Nothing to be done for 'install-data-am'.
make[2]: Leaving directory '/private/tmp/nix-build-form-4.2.0.drv-0/form-4.2.0'
make[1]: Leaving directory '/private/tmp/nix-build-form-4.2.0.drv-0/form-4.2.0'
post-installation fixup
gzipping man pages under /nix/store/9pwsyyvnsx67wvgd1kv38wkbk3b86kny-form-4.2.0/share/man/
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/9pwsyyvnsx67wvgd1kv38wkbk3b86kny-form-4.2.0/bin
patching script interpreter paths in /nix/store/9pwsyyvnsx67wvgd1kv38wkbk3b86kny-form-4.2.0
/nix/store/9pwsyyvnsx67wvgd1kv38wkbk3b86kny-form-4.2.0

@xeji xeji merged commit 65c3273 into NixOS:master May 22, 2018
@veprbl veprbl deleted the pr/form branch December 1, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @GrahamcOfBorg @xeji