Pass game instance from cmdline to GUI/ConsoleUI #2449
Merged
+20
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If you have multiple game instances, you can choose between them with these command line options:
However, these currently don't work for GUI or ConsoleUI. Instead, they will use the default instance if one is defined, or ask the user to choose an instance.
For GUI, these options are allowed and parsed (to the extent of raising an error if an invalid instance is specified), but not used to drive the UI.
For ConsoleUI, these options are not considered valid.
Changes
Now the
--kspand--kspdirflags work for both GUI and ConsoleUI.The knowledge of which instance to use is stored into
CmdLine'sKSPManagerobject byInstanceSpecificOptions.Handle. To make GUI and ConsoleUI obey this, we pass this same manager object to them via new parameters.Fixes https://forum.kerbalspaceprogram.com/index.php?/topic/154922-ckan-the-comprehensive-kerbal-archive-network-v1251-broglio/&do=findComment&comment=3380669