Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memo: 0.2 -> 0.4 #40697

Merged
merged 1 commit into from May 25, 2018
Merged

memo: 0.2 -> 0.4 #40697

merged 1 commit into from May 25, 2018

Conversation

mrVanDalo
Copy link
Contributor

Motivation for this change

Version bump (with some new features)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented May 17, 2018

@GrahamcOfBorg build memo

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: memo

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: memo

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hlf64iiqsq064x4hxnl9vjqwx9q91gn2-memo-0.3
gzipping man pages under /nix/store/hlf64iiqsq064x4hxnl9vjqwx9q91gn2-memo-0.3/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hlf64iiqsq064x4hxnl9vjqwx9q91gn2-memo-0.3/bin
patching script interpreter paths in /nix/store/hlf64iiqsq064x4hxnl9vjqwx9q91gn2-memo-0.3
/nix/store/hlf64iiqsq064x4hxnl9vjqwx9q91gn2-memo-0.3/bin/memo: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/hlf64iiqsq064x4hxnl9vjqwx9q91gn2-memo-0.3...
/nix/store/hlf64iiqsq064x4hxnl9vjqwx9q91gn2-memo-0.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: memo

Partial log (click to expand)

building
no Makefile, doing nothing
installing
post-installation fixup
gzipping man pages under /nix/store/axjfjvlrbcp4917b7izhc6ks486say2k-memo-0.3/share/man/
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/axjfjvlrbcp4917b7izhc6ks486say2k-memo-0.3/bin
patching script interpreter paths in /nix/store/axjfjvlrbcp4917b7izhc6ks486say2k-memo-0.3
/nix/store/axjfjvlrbcp4917b7izhc6ks486say2k-memo-0.3/bin/memo: interpreter directive changed from "/bin/bash" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/bash"
/nix/store/axjfjvlrbcp4917b7izhc6ks486say2k-memo-0.3

@xeji
Copy link
Contributor

xeji commented May 17, 2018

The new dependency on pandoc causes aarch64 build to fail (Haskell is currently broken on aarch64) and increases closure size. You may want to consider making pandoc support optional.

@mrVanDalo
Copy link
Contributor Author

Oh. Yeah I'll create a task for that an will fix that in the next days.

@xeji
Copy link
Contributor

xeji commented May 17, 2018

Marking this as WIP until then.

@mrVanDalo
Copy link
Contributor Author

mrVanDalo commented May 24, 2018 •
edited

@xeji I made pandoc optional. Is there more to do for the aarch64 platform ?

@mrVanDalo mrVanDalo changed the title memo: 0.2 -> 0.3 memo: 0.2 -> 0.4 May 24, 2018
@xeji
Copy link
Contributor

xeji commented May 25, 2018

@GrahamcOfBorg build memo

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: memo

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/s6lgpa390an8kjwn1bvi9fsynfqmy4ya-memo-0.4
gzipping man pages under /nix/store/s6lgpa390an8kjwn1bvi9fsynfqmy4ya-memo-0.4/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/s6lgpa390an8kjwn1bvi9fsynfqmy4ya-memo-0.4/bin
patching script interpreter paths in /nix/store/s6lgpa390an8kjwn1bvi9fsynfqmy4ya-memo-0.4
/nix/store/s6lgpa390an8kjwn1bvi9fsynfqmy4ya-memo-0.4/bin/memo: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/s6lgpa390an8kjwn1bvi9fsynfqmy4ya-memo-0.4...
/nix/store/s6lgpa390an8kjwn1bvi9fsynfqmy4ya-memo-0.4

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: memo

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: memo

Partial log (click to expand)

building
no Makefile, doing nothing
installing
post-installation fixup
gzipping man pages under /nix/store/ld6mmqk6np77yfsiskfjsqh7x7jvaqv1-memo-0.4/share/man/
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/ld6mmqk6np77yfsiskfjsqh7x7jvaqv1-memo-0.4/bin
patching script interpreter paths in /nix/store/ld6mmqk6np77yfsiskfjsqh7x7jvaqv1-memo-0.4
/nix/store/ld6mmqk6np77yfsiskfjsqh7x7jvaqv1-memo-0.4/bin/memo: interpreter directive changed from "/bin/bash" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/bash"
/nix/store/ld6mmqk6np77yfsiskfjsqh7x7jvaqv1-memo-0.4

@xeji
Copy link
Contributor

xeji commented May 25, 2018

Thank you, looks good.

@xeji xeji merged commit 6f193b4 into NixOS:master May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrVanDalo @xeji @GrahamcOfBorg