Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make getHaskellBuildInputs / shellFor work with overrideCabal (Fixes #40266) #40710

Merged
merged 1 commit into from May 22, 2018
Merged

Make getHaskellBuildInputs / shellFor work with overrideCabal (Fixes #40266) #40710

merged 1 commit into from May 22, 2018

Conversation

ElvishJerricco
Copy link
Contributor

Motivation for this change

Fixing #40266

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ElvishJerricco ElvishJerricco requested a review from peti as a code owner May 18, 2018 00:37
luigy added a commit to reflex-frp/reflex-platform that referenced this pull request May 18, 2018
@luigy
Make workOnMulti work with overrideCabal
15a283f 
Backport of NixOS/nixpkgs#40710
@peti peti requested review from shlevy and removed request for peti May 21, 2018 11:40
luigy added a commit to reflex-frp/reflex-platform that referenced this pull request May 21, 2018
@luigy
Make workOnMulti work with overrideCabal
963638c 
Backport of NixOS/nixpkgs#40710
@peti peti merged commit 07a0459 into NixOS:master May 22, 2018
@4e6 4e6 mentioned this pull request Jun 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlevy shlevy shlevy approved these changes

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ElvishJerricco @shlevy @peti @GrahamcOfBorg