Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command-line replay by others, finish watching => assert #332

Closed
SimonN opened this issue May 17, 2018 · 2 comments
Closed

Command-line replay by others, finish watching => assert #332

SimonN opened this issue May 17, 2018 · 2 comments
Labels
3-bug

Comments

@SimonN
Copy link
Owner

SimonN commented May 17, 2018

Lix 0.9.16.

Have a replay by somebody else.
Watch it from the command line: bin/lix path/to/replay.txt
Watch it entirely and don't click with the mouse. [1]
After the replay, we go back to the singleplayer browser. [2]
Singleplayer browser tries to save checkmark and fails an assertion because the replay's player is different from us.

Expected: No assertion failure. Ideally, change [2] already: The main menu or the replay browser seem better places to land from here.

[1] If you click with the mouse before watching the replay, the replay in RAM will become yours (instead of somebody else's) and won't crash singleplayer.
@SimonN SimonN added the 3-bug label May 17, 2018
@SimonN
Copy link
Owner Author

SimonN commented May 18, 2018

I have a fix in unstable.

Bug left behind in that fix: When you watch from the command-line your own replay, it gets autosaved a second time even though you haven't change it during the watching.

@SimonN
Copy link
Owner Author

SimonN commented Jun 29, 2018

Doesn't happen anymore in 0.9.17.

@SimonN SimonN closed this as completed Jun 29, 2018
geoo89 pushed a commit to geoo89/LixD that referenced this issue Jun 19, 2022
@SimonN
fix SimonN#332: Tile group relative coords are >= 0
b396a27 
This fix saves tile groups such that their relative-to-group coordinates
are always >= 0.

Before, tiles with transparent boundaries could generate tile groups
with relative coordinates < 0. These groups would wrap when added to a
torus map. This wrapping is a second questionable design because only
tiles directly added to the map should get wrapped. But for backwards
compatibility/physics compatibility with all 0.9.x, I will not change
that wrapping yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3-bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SimonN