Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install shell completions for beets, borg, exa, youtube-dl #40457

Merged
merged 4 commits into from May 13, 2018

Conversation

jfrankenau
Copy link
Member

Motivation for this change

Missing shell completions and in the case of exa also a missing man page.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cp scripts/shell_completions/bash/borg $out/share/bash-completion/completions/

mkdir -p $out/share/fish/completions
cp scripts/shell_completions/fish/borg.fish $out/share/fish/completions/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be $out/share/fish/vendor_completions.d, same below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@dotlambda dotlambda merged commit 6a5b1fd into NixOS:master May 13, 2018
@jfrankenau jfrankenau deleted the zsh-completions branch August 10, 2018 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants