avocode: init at 2.26.0 #40425
Merged
avocode: init at 2.26.0 #40425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
reviewed
May 13, 2018
| comment = "The bridge between designers and developers"; | ||
| }; | ||
|
|
||
| dontBuild= true; |
| buildInputs = [unzip]; | ||
| nativeBuildInputs = [ makeWrapper ]; | ||
|
|
||
| buildCommand = '' |
There was a problem hiding this comment.
Why use buildCommand instead of the standard phases? You already set dontBuild = true, so you may as well describe an installPhase and a postFixup.
|
@FRidh Thanks for feedback. Updated the PR. |
FRidh
requested changes
May 13, 2018
|
|
||
| buildInputs = [ unzip ]; | ||
|
|
||
| unpackCmd = '' |
There was a problem hiding this comment.
no need for this because the builder already does that (though you might need fetchzip instead of fetchurl)
There was a problem hiding this comment.
fetchzip and the normal unpackPhase expect the unzip command to produce a single directory. That is not the case for the sources of avocode.
There was a problem hiding this comment.
I see. That isn't clear from the code, so include a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add avocode package
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)