Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matomo: 3.4.0 -> 3.5.0 #40439

Merged
merged 1 commit into from May 13, 2018
Merged

matomo: 3.4.0 -> 3.5.0 #40439

merged 1 commit into from May 13, 2018

Conversation

florianjacob
Copy link
Contributor

Motivation for this change

The new matomo release brings new features required for compyling with GDPR, which will get in effect on May 25th. See the release announcement for more information.

Maintainer of matomo here, this should be backported this to stable. I see only a minimal risk for breakage, while those new features are strictly required for operating Matomo when targeting EU visitors as soon as GPDR is binding.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented May 13, 2018

@GrahamcOfBorg build matomo

@xeji xeji added the 9.needs: port to stable A PR needs a backport to the stable release. label May 13, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: matomo

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/02f2vwj2z7rpdrsh09fb65fzc9g988lc-matomo-3.5.0/bin
patching script interpreter paths in /nix/store/02f2vwj2z7rpdrsh09fb65fzc9g988lc-matomo-3.5.0
/nix/store/02f2vwj2z7rpdrsh09fb65fzc9g988lc-matomo-3.5.0/share/misc/composer/build-xhprof.sh: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/02f2vwj2z7rpdrsh09fb65fzc9g988lc-matomo-3.5.0/share/misc/composer/clean-xhprof.sh: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/02f2vwj2z7rpdrsh09fb65fzc9g988lc-matomo-3.5.0/share/misc/cron/archive.sh: interpreter directive changed from "/bin/sh -e" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh -e"
/nix/store/02f2vwj2z7rpdrsh09fb65fzc9g988lc-matomo-3.5.0/share/vendor/maxmind/web-service-common/dev-bin/release.sh: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/02f2vwj2z7rpdrsh09fb65fzc9g988lc-matomo-3.5.0/share/vendor/leafo/lessphp/package.sh: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/02f2vwj2z7rpdrsh09fb65fzc9g988lc-matomo-3.5.0/share/vendor/pear/archive_tar/sync-php4: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/02f2vwj2z7rpdrsh09fb65fzc9g988lc-matomo-3.5.0...
/nix/store/02f2vwj2z7rpdrsh09fb65fzc9g988lc-matomo-3.5.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: matomo

Partial log (click to expand)

strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/7bkq2mpg7a5d627blw2bhcizy85r5m14-matomo-3.5.0/bin
patching script interpreter paths in /nix/store/7bkq2mpg7a5d627blw2bhcizy85r5m14-matomo-3.5.0
/nix/store/7bkq2mpg7a5d627blw2bhcizy85r5m14-matomo-3.5.0/share/misc/composer/build-xhprof.sh: interpreter directive changed from "/bin/bash" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/bash"
/nix/store/7bkq2mpg7a5d627blw2bhcizy85r5m14-matomo-3.5.0/share/misc/composer/clean-xhprof.sh: interpreter directive changed from "/bin/bash" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/bash"
/nix/store/7bkq2mpg7a5d627blw2bhcizy85r5m14-matomo-3.5.0/share/misc/cron/archive.sh: interpreter directive changed from "/bin/sh -e" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/sh -e"
/nix/store/7bkq2mpg7a5d627blw2bhcizy85r5m14-matomo-3.5.0/share/vendor/pear/archive_tar/sync-php4: interpreter directive changed from "/bin/sh" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/sh"
/nix/store/7bkq2mpg7a5d627blw2bhcizy85r5m14-matomo-3.5.0/share/vendor/maxmind/web-service-common/dev-bin/release.sh: interpreter directive changed from "/bin/bash" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/bash"
/nix/store/7bkq2mpg7a5d627blw2bhcizy85r5m14-matomo-3.5.0/share/vendor/leafo/lessphp/package.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/sh"
/nix/store/7bkq2mpg7a5d627blw2bhcizy85r5m14-matomo-3.5.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: matomo

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/x5g8affw5wl2ppwbdwlip70gprhijmr4-matomo-3.5.0/bin
patching script interpreter paths in /nix/store/x5g8affw5wl2ppwbdwlip70gprhijmr4-matomo-3.5.0
/nix/store/x5g8affw5wl2ppwbdwlip70gprhijmr4-matomo-3.5.0/share/vendor/pear/archive_tar/sync-php4: interpreter directive changed from "/bin/sh" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh"
/nix/store/x5g8affw5wl2ppwbdwlip70gprhijmr4-matomo-3.5.0/share/vendor/leafo/lessphp/package.sh: interpreter directive changed from "/bin/sh" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh"
/nix/store/x5g8affw5wl2ppwbdwlip70gprhijmr4-matomo-3.5.0/share/vendor/maxmind/web-service-common/dev-bin/release.sh: interpreter directive changed from "/bin/bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
/nix/store/x5g8affw5wl2ppwbdwlip70gprhijmr4-matomo-3.5.0/share/misc/cron/archive.sh: interpreter directive changed from "/bin/sh -e" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh -e"
/nix/store/x5g8affw5wl2ppwbdwlip70gprhijmr4-matomo-3.5.0/share/misc/composer/clean-xhprof.sh: interpreter directive changed from "/bin/bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
/nix/store/x5g8affw5wl2ppwbdwlip70gprhijmr4-matomo-3.5.0/share/misc/composer/build-xhprof.sh: interpreter directive changed from "/bin/bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/x5g8affw5wl2ppwbdwlip70gprhijmr4-matomo-3.5.0...
/nix/store/x5g8affw5wl2ppwbdwlip70gprhijmr4-matomo-3.5.0

@xeji xeji merged commit 468c09e into NixOS:master May 13, 2018
@xeji
Copy link
Contributor

xeji commented May 13, 2018

@florianjacob I understand your reasons for asking to backport this (thanks EU for creating another regulatory nightmare with good intentions), but https://developer.matomo.org/changelog mentions a breaking API change. How should we deal with this?

@florianjacob florianjacob deleted the matomo branch May 13, 2018 16:25
@florianjacob
Copy link
Contributor Author

@xeji yes, that API change can lead to broken plugins not compatible with 3.5.0, but this should not affect us, as the NixOS matomo module does not support installing additional plugins, neither from marketplace nor custom ones. Only the Core Plugins shipped with the release do work, and they are compatible.

“Should not affect us”, as in “does not affect us, unless someone found a clever way how it's possible to install plugins that they did not tell me about or upstream it, but it doesn't work out of the box and I'm quite sure it's not trivial”.

(:+1: for verifying my claims!)

xeji pushed a commit that referenced this pull request May 13, 2018
@florianjacob @xeji
matomo: 3.4.0 -> 3.5.0 (#40439)
efd2add 
(cherry picked from commit 468c09e)
@xeji
Copy link
Contributor

xeji commented May 13, 2018

Thanks for explaining. Backported in efd2add

@florianjacob
Copy link
Contributor Author

@xeji thanks!

/me goes back at having fun with privacy policies and data asset registers…

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@florianjacob @xeji @GrahamcOfBorg @samueldr