Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Fixes documented default option for <name> for submodules. #40464

Merged
merged 1 commit into from
May 16, 2018
Merged

doc: Fixes documented default option for <name> for submodules. #40464

merged 1 commit into from
May 16, 2018
+7 −1

Conversation

samueldr
Copy link
Member

Fixes #40463

This is related to change 1d56d0c

Motivation for this change

Example from the man page:

       security.acme.certs.<name>.domain
           Domain to fetch certificate for (defaults to the entry name)
           Type: string
           Default: "‹name›"
           Declared by:
               <nixpkgs/nixos/modules/security/acme.nix>

Example from the (local) manual:

20180513204100

Things done
  • ✔️ Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • ✔️ NixOS
    • ❌ macOS
    • ❌ other Linux distributions
  • ❌ Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • ✔️ Fits CONTRIBUTING.md.

@samueldr
doc: Fixes documented default option for <name> for submodules.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
4213279 
Fixes NixOS#40463

This is related to change 1d56d0c
@samueldr samueldr requested review from edolstra and nbp as code owners May 14, 2018 00:42
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 14, 2018
@xeji xeji merged commit 136f1c4 into NixOS:master May 16, 2018
@samueldr samueldr deleted the fix/submodule-name-documentation branch June 1, 2018 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra

@nbp nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samueldr @GrahamcOfBorg @xeji