linuxPackages.bcc: make it useable as a python library #40426

Mic92 · 2018-05-13T09:52:43Z

Motivation for this change

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Mic92 · 2018-05-13T09:55:22Z

pkgs/os-specific/linux/bcc/default.nix

    done
  '';

+  postFixup = ''
+    wrapPythonProgramsIn "$out/share/bcc/tools" "$out $pythonPath"


deadlock-detector is still broken because of this: #40427

Mic92 · 2018-05-13T09:58:11Z

@GrahamcOfBorg build linuxPackages.bcc

GrahamcOfBorg · 2018-05-13T09:58:40Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: linuxPackages.bcc

Partial log (click to expand)

while evaluating the attribute 'linux_4_14' at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix�[0m:13477:3:
while evaluating 'callPackageWith' at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:113:35, called from �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix�[0m:13477:16:
while evaluating 'makeOverridable' at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:72:24, called from �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:117:8:
while evaluating anonymous function at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/linux-4.14.nix�[0m:1:1, called from �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:74:12:
while evaluating 'buildLinux' at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix�[0m:13769:16, called from �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/linux-4.14.nix�[0m:5:1:
while evaluating 'callPackageWith' at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:113:35, called from �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix�[0m:13769:23:
while evaluating 'makeOverridable' at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:72:24, called from �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:117:8:
while evaluating anonymous function at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/generic.nix�[0m:1:1, called from �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:74:12:
assertion failed at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/generic.nix�[0m:45:1

GrahamcOfBorg · 2018-05-13T09:58:43Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: linuxPackages.bcc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-05-13T09:58:45Z

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: linuxPackages.bcc

Partial log (click to expand)

Cannot nix-instantiate `linuxPackages.bcc' because:
error: while evaluating the attribute 'postPatch' of the derivation 'bcc-0.5.0' at /home/ofborg/ofborg3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c3/pkgs/stdenv/generic/make-derivation.nix:148:11:
getting status of '/home/ofborg/ofborg3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c3/pkgs/os-specific/linux/bcc/libbcc-path.patch': No such file or directory

GrahamcOfBorg · 2018-05-13T10:12:44Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: linuxPackages.bcc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-05-13T10:12:52Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: linuxPackages.bcc

Partial log (click to expand)

while evaluating the attribute 'linux_4_14' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:13477:3:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:113:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:13477:16:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:72:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:117:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/linux-4.14.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:74:12:
while evaluating 'buildLinux' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:13769:16, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/linux-4.14.nix:5:1:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:113:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:13769:23:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:72:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:117:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/generic.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:74:12:
assertion failed at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/generic.nix:45:1

GrahamcOfBorg · 2018-05-13T10:13:50Z

Success on x86_64-linux (full log)

Attempted: linuxPackages.bcc

Partial log (click to expand)

wrapping `/nix/store/0fhpk4np0p2hi0f3m24flzlqydzdjj6y-bcc-0.5.0/share/bcc/tools/trace'...
wrapping `/nix/store/0fhpk4np0p2hi0f3m24flzlqydzdjj6y-bcc-0.5.0/share/bcc/tools/ttysnoop'...
wrapping `/nix/store/0fhpk4np0p2hi0f3m24flzlqydzdjj6y-bcc-0.5.0/share/bcc/tools/vfscount'...
wrapping `/nix/store/0fhpk4np0p2hi0f3m24flzlqydzdjj6y-bcc-0.5.0/share/bcc/tools/vfsstat'...
wrapping `/nix/store/0fhpk4np0p2hi0f3m24flzlqydzdjj6y-bcc-0.5.0/share/bcc/tools/wakeuptime'...
wrapping `/nix/store/0fhpk4np0p2hi0f3m24flzlqydzdjj6y-bcc-0.5.0/share/bcc/tools/xfsdist'...
wrapping `/nix/store/0fhpk4np0p2hi0f3m24flzlqydzdjj6y-bcc-0.5.0/share/bcc/tools/xfsslower'...
wrapping `/nix/store/0fhpk4np0p2hi0f3m24flzlqydzdjj6y-bcc-0.5.0/share/bcc/tools/zfsdist'...
wrapping `/nix/store/0fhpk4np0p2hi0f3m24flzlqydzdjj6y-bcc-0.5.0/share/bcc/tools/zfsslower'...
/nix/store/0fhpk4np0p2hi0f3m24flzlqydzdjj6y-bcc-0.5.0

Mic92 · 2018-05-29T13:24:43Z

@teto anything I miss out here?

GrahamcOfBorg · 2018-05-29T13:43:06Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: linuxPackages.bcc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-05-29T13:43:27Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: linuxPackages.bcc

Partial log (click to expand)

while evaluating the attribute 'linux_4_14' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:13477:3:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:113:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:13477:16:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:72:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:117:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/linux-4.14.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:74:12:
while evaluating 'buildLinux' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:13768:16, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/linux-4.14.nix:5:1:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:113:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:13768:23:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:72:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:117:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/generic.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:74:12:
assertion failed at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/generic.nix:45:1

GrahamcOfBorg · 2018-05-29T14:01:45Z

Success on x86_64-linux (full log)

Attempted: linuxPackages.bcc

Partial log (click to expand)

wrapping `/nix/store/d90chi5qw76bbncy4b1b0qb2m065c7yh-bcc-0.5.0/share/bcc/tools/trace'...
wrapping `/nix/store/d90chi5qw76bbncy4b1b0qb2m065c7yh-bcc-0.5.0/share/bcc/tools/ttysnoop'...
wrapping `/nix/store/d90chi5qw76bbncy4b1b0qb2m065c7yh-bcc-0.5.0/share/bcc/tools/vfscount'...
wrapping `/nix/store/d90chi5qw76bbncy4b1b0qb2m065c7yh-bcc-0.5.0/share/bcc/tools/vfsstat'...
wrapping `/nix/store/d90chi5qw76bbncy4b1b0qb2m065c7yh-bcc-0.5.0/share/bcc/tools/wakeuptime'...
wrapping `/nix/store/d90chi5qw76bbncy4b1b0qb2m065c7yh-bcc-0.5.0/share/bcc/tools/xfsdist'...
wrapping `/nix/store/d90chi5qw76bbncy4b1b0qb2m065c7yh-bcc-0.5.0/share/bcc/tools/xfsslower'...
wrapping `/nix/store/d90chi5qw76bbncy4b1b0qb2m065c7yh-bcc-0.5.0/share/bcc/tools/zfsdist'...
wrapping `/nix/store/d90chi5qw76bbncy4b1b0qb2m065c7yh-bcc-0.5.0/share/bcc/tools/zfsslower'...
/nix/store/d90chi5qw76bbncy4b1b0qb2m065c7yh-bcc-0.5.0

teto · 2018-05-29T14:14:24Z

pkgs/os-specific/linux/bcc/default.nix

+  postPatch = ''
+    substituteAll ${./libbcc-path.patch} ./libbcc-path.patch
+    patch -p1 < libbcc-path.patch
+  '';


I find the https://github.com/NixOS/nixpkgs/pull/41196/files#diff-c74e966bd35a02adf1e310fbcf2c8dd5R36 easier to maintain/read/understand.

It is easier to understand but it can also silently break after updates. I added this patch so when updating bcc we can be sure it still replaces the right thing.

Mic92 commented May 13, 2018

View reviewed changes

Mic92 force-pushed the bcc branch from 0a5769c to 1b7ad25 Compare May 13, 2018 09:59

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 labels May 13, 2018

GrahamcOfBorg added the 2.status: merge conflict label May 29, 2018

Mic92 force-pushed the bcc branch from 63b17fd to 92e21a1 Compare May 29, 2018 13:24

GrahamcOfBorg removed the 2.status: merge conflict label May 29, 2018

Mic92 force-pushed the bcc branch from 92e21a1 to 1c5f182 Compare May 29, 2018 13:28

linuxPackages.bcc: make it useable as a python library

c52dff6

Mic92 force-pushed the bcc branch from 1c5f182 to c52dff6 Compare May 29, 2018 13:30

teto reviewed May 29, 2018

View reviewed changes

Mic92 merged commit 46a9466 into NixOS:master May 29, 2018

Mic92 deleted the bcc branch May 29, 2018 19:07

teto mentioned this pull request May 30, 2018

[wip] pythonPackages.bcc-python: init at 0.5 #41196

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

linuxPackages.bcc: make it useable as a python library #40426

linuxPackages.bcc: make it useable as a python library #40426

Mic92 commented May 13, 2018 •

edited

Mic92 May 13, 2018

Mic92 commented May 13, 2018

GrahamcOfBorg commented May 13, 2018

GrahamcOfBorg commented May 13, 2018

GrahamcOfBorg commented May 13, 2018

GrahamcOfBorg commented May 13, 2018

GrahamcOfBorg commented May 13, 2018

GrahamcOfBorg commented May 13, 2018

Mic92 commented May 29, 2018

GrahamcOfBorg commented May 29, 2018

GrahamcOfBorg commented May 29, 2018

GrahamcOfBorg commented May 29, 2018

teto May 29, 2018

Mic92 May 29, 2018

linuxPackages.bcc: make it useable as a python library #40426

linuxPackages.bcc: make it useable as a python library #40426

Conversation

Mic92 commented May 13, 2018 • edited

Motivation for this change

Things done

Mic92 May 13, 2018

Choose a reason for hiding this comment

Mic92 commented May 13, 2018

GrahamcOfBorg commented May 13, 2018

GrahamcOfBorg commented May 13, 2018

GrahamcOfBorg commented May 13, 2018

GrahamcOfBorg commented May 13, 2018

GrahamcOfBorg commented May 13, 2018

GrahamcOfBorg commented May 13, 2018

Mic92 commented May 29, 2018

GrahamcOfBorg commented May 29, 2018

GrahamcOfBorg commented May 29, 2018

GrahamcOfBorg commented May 29, 2018

teto May 29, 2018

Choose a reason for hiding this comment

Mic92 May 29, 2018

Choose a reason for hiding this comment

Mic92 commented May 13, 2018 •

edited