Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

giac: re-add lapack without atlas #40458

Merged
merged 1 commit into from May 14, 2018
Merged

giac: re-add lapack without atlas #40458

merged 1 commit into from May 14, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented May 13, 2018 •
edited

Motivation for this change

Fixes the remaining liblapack configureFlag, see #40430.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@timokau timokau mentioned this pull request May 13, 2018
Merged
8 tasks
@symphorien
Copy link
Member

I you want to spend the time to open a new PR, wouldn't it be better to readd liblapack (but without atlas, since this is painful) ?
as you wish, the added functionality is nearly 0.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: giac

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: giac

Partial log (click to expand)

shrinking /nix/store/f5cdixhrpmdlx9n3hbsmsb3y2749r40c-giac-1.4.9-59/bin/cas_help
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/f5cdixhrpmdlx9n3hbsmsb3y2749r40c-giac-1.4.9-59/lib  /nix/store/f5cdixhrpmdlx9n3hbsmsb3y2749r40c-giac-1.4.9-59/bin
patching script interpreter paths in /nix/store/f5cdixhrpmdlx9n3hbsmsb3y2749r40c-giac-1.4.9-59
/nix/store/f5cdixhrpmdlx9n3hbsmsb3y2749r40c-giac-1.4.9-59/bin/pgiac: interpreter directive changed from "/usr/bin/perl" to "/nix/store/cxdmh98g0lvl1dyq304c1lq7f90dh01f-perl-5.24.3/bin/perl"
checking for references to /build in /nix/store/f5cdixhrpmdlx9n3hbsmsb3y2749r40c-giac-1.4.9-59...
shrinking RPATHs of ELF executables and libraries in /nix/store/p4gz3rqnfdsyaxqlf4lr3bqn7r6zk2sw-giac-1.4.9-59-doc
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/p4gz3rqnfdsyaxqlf4lr3bqn7r6zk2sw-giac-1.4.9-59-doc
checking for references to /build in /nix/store/p4gz3rqnfdsyaxqlf4lr3bqn7r6zk2sw-giac-1.4.9-59-doc...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: giac

Partial log (click to expand)

strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/81cc4b8md6wybsca2r4pqsac04bpjy53-giac-1.4.9-59/lib  /nix/store/81cc4b8md6wybsca2r4pqsac04bpjy53-giac-1.4.9-59/bin
patching script interpreter paths in /nix/store/81cc4b8md6wybsca2r4pqsac04bpjy53-giac-1.4.9-59
/nix/store/81cc4b8md6wybsca2r4pqsac04bpjy53-giac-1.4.9-59/bin/pgiac: interpreter directive changed from "/usr/bin/perl" to "/nix/store/13fsgz2l89qflb0ycc5lyxgigpral6g6-perl-5.24.3/bin/perl"
checking for references to /build in /nix/store/81cc4b8md6wybsca2r4pqsac04bpjy53-giac-1.4.9-59...
shrinking RPATHs of ELF executables and libraries in /nix/store/gcwyzlvh9zi6661vm860y640vvlwrhkm-giac-1.4.9-59-doc
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/gcwyzlvh9zi6661vm860y640vvlwrhkm-giac-1.4.9-59-doc
checking for references to /build in /nix/store/gcwyzlvh9zi6661vm860y640vvlwrhkm-giac-1.4.9-59-doc...
/nix/store/81cc4b8md6wybsca2r4pqsac04bpjy53-giac-1.4.9-59

@timokau
Copy link
Member Author

timokau commented May 13, 2018

If you prefer that, I'm fine with it.

@GrahamcOfBorg build giac-with-xcas

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: giac-with-xcas

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: giac-with-xcas

Partial log (click to expand)

shrinking /nix/store/s8j7671bjm92lzl6jjpq3an1i65hkxb3-giac-with-xcas-1.4.9-59/bin/cas_help
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/s8j7671bjm92lzl6jjpq3an1i65hkxb3-giac-with-xcas-1.4.9-59/lib  /nix/store/s8j7671bjm92lzl6jjpq3an1i65hkxb3-giac-with-xcas-1.4.9-59/bin
patching script interpreter paths in /nix/store/s8j7671bjm92lzl6jjpq3an1i65hkxb3-giac-with-xcas-1.4.9-59
/nix/store/s8j7671bjm92lzl6jjpq3an1i65hkxb3-giac-with-xcas-1.4.9-59/bin/pgiac: interpreter directive changed from "/usr/bin/perl" to "/nix/store/cxdmh98g0lvl1dyq304c1lq7f90dh01f-perl-5.24.3/bin/perl"
checking for references to /build in /nix/store/s8j7671bjm92lzl6jjpq3an1i65hkxb3-giac-with-xcas-1.4.9-59...
shrinking RPATHs of ELF executables and libraries in /nix/store/h3z0s5j8jnml4d1cvjf784hkwhxr8wpy-giac-with-xcas-1.4.9-59-doc
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/h3z0s5j8jnml4d1cvjf784hkwhxr8wpy-giac-with-xcas-1.4.9-59-doc
checking for references to /build in /nix/store/h3z0s5j8jnml4d1cvjf784hkwhxr8wpy-giac-with-xcas-1.4.9-59-doc...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: giac-with-xcas

Partial log (click to expand)

strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/i5galm6zis267d1faq9bsncscxans88y-giac-with-xcas-1.4.9-59/lib  /nix/store/i5galm6zis267d1faq9bsncscxans88y-giac-with-xcas-1.4.9-59/bin
patching script interpreter paths in /nix/store/i5galm6zis267d1faq9bsncscxans88y-giac-with-xcas-1.4.9-59
/nix/store/i5galm6zis267d1faq9bsncscxans88y-giac-with-xcas-1.4.9-59/bin/pgiac: interpreter directive changed from "/usr/bin/perl" to "/nix/store/13fsgz2l89qflb0ycc5lyxgigpral6g6-perl-5.24.3/bin/perl"
checking for references to /build in /nix/store/i5galm6zis267d1faq9bsncscxans88y-giac-with-xcas-1.4.9-59...
shrinking RPATHs of ELF executables and libraries in /nix/store/ldbkafy6fi5vgc6bvgh3k30wvayagdl0-giac-with-xcas-1.4.9-59-doc
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/ldbkafy6fi5vgc6bvgh3k30wvayagdl0-giac-with-xcas-1.4.9-59-doc
checking for references to /build in /nix/store/ldbkafy6fi5vgc6bvgh3k30wvayagdl0-giac-with-xcas-1.4.9-59-doc...
/nix/store/i5galm6zis267d1faq9bsncscxans88y-giac-with-xcas-1.4.9-59

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: giac

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: giac

Partial log (click to expand)

shrinking /nix/store/98r5a59bip3f94yhfb04z4gw1v9dj788-giac-1.4.9-59/lib/libgiac.so.0.0.0
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/98r5a59bip3f94yhfb04z4gw1v9dj788-giac-1.4.9-59/lib  /nix/store/98r5a59bip3f94yhfb04z4gw1v9dj788-giac-1.4.9-59/bin
patching script interpreter paths in /nix/store/98r5a59bip3f94yhfb04z4gw1v9dj788-giac-1.4.9-59
/nix/store/98r5a59bip3f94yhfb04z4gw1v9dj788-giac-1.4.9-59/bin/pgiac: interpreter directive changed from "/usr/bin/perl" to "/nix/store/cxdmh98g0lvl1dyq304c1lq7f90dh01f-perl-5.24.3/bin/perl"
checking for references to /build in /nix/store/98r5a59bip3f94yhfb04z4gw1v9dj788-giac-1.4.9-59...
shrinking RPATHs of ELF executables and libraries in /nix/store/7m00wxwnpydh6v0jsz2sxn8x4k6y8jn8-giac-1.4.9-59-doc
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/7m00wxwnpydh6v0jsz2sxn8x4k6y8jn8-giac-1.4.9-59-doc
checking for references to /build in /nix/store/7m00wxwnpydh6v0jsz2sxn8x4k6y8jn8-giac-1.4.9-59-doc...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: giac

Partial log (click to expand)

strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5wf347fbsv1ds18y1msfkdps4z93p7ff-giac-1.4.9-59/lib  /nix/store/5wf347fbsv1ds18y1msfkdps4z93p7ff-giac-1.4.9-59/bin
patching script interpreter paths in /nix/store/5wf347fbsv1ds18y1msfkdps4z93p7ff-giac-1.4.9-59
/nix/store/5wf347fbsv1ds18y1msfkdps4z93p7ff-giac-1.4.9-59/bin/pgiac: interpreter directive changed from "/usr/bin/perl" to "/nix/store/13fsgz2l89qflb0ycc5lyxgigpral6g6-perl-5.24.3/bin/perl"
checking for references to /build in /nix/store/5wf347fbsv1ds18y1msfkdps4z93p7ff-giac-1.4.9-59...
shrinking RPATHs of ELF executables and libraries in /nix/store/fzrhbjan6zv3fp63pscikwzpmv1v30mp-giac-1.4.9-59-doc
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/fzrhbjan6zv3fp63pscikwzpmv1v30mp-giac-1.4.9-59-doc
checking for references to /build in /nix/store/fzrhbjan6zv3fp63pscikwzpmv1v30mp-giac-1.4.9-59-doc...
/nix/store/5wf347fbsv1ds18y1msfkdps4z93p7ff-giac-1.4.9-59

@xeji xeji changed the title giac: Remove lapack configFlag (#40430) giac: re-add lapack without atlas May 14, 2018
@xeji xeji merged commit 053d1e0 into NixOS:master May 14, 2018
@timokau timokau deleted the giac-liblapack2 branch May 14, 2018 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timokau @symphorien @GrahamcOfBorg @xeji