Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytorch: 0.3.1 -> 0.4.0 #40453

Merged
merged 1 commit into from May 15, 2018
Merged

pytorch: 0.3.1 -> 0.4.0 #40453

merged 1 commit into from May 15, 2018

Conversation

andersk
Copy link
Contributor

@andersk andersk commented May 13, 2018

Signed-off-by: Anders Kaseorg andersk@mit.edu

Motivation for this change

Upgrade PyTorch from 0.3.1 to 0.4.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@andersk
pytorch: 0.3.1 -> 0.4.0
d2f7acf 
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk andersk requested a review from FRidh as a code owner May 13, 2018 18:50
@nlewo
Copy link
Member

nlewo commented May 14, 2018

cc @teh

@nlewo
Copy link
Member

nlewo commented May 14, 2018

@GrahamcOfBorg build pythonPackages.pytorch

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.pytorch

Partial log (click to expand)

common.py:446: RuntimeWarning: could not download test file 'https://download.pytorch.org/test_data/legacy_modules.t7'
  warnings.warn(msg, RuntimeWarning)
.sError: failed to parse the list of possible procesors in /sys/devices/system/cpu/possible
Error: failed to parse the list of present procesors in /sys/devices/system/cpu/present
.......ss.......
----------------------------------------------------------------------
Ran 18 tests in 2.653s

OK (skipped=3)
/nix/store/8lhrqgqlg8p9a0y3z1jc767r7azikhcw-python2.7-pytorch-0.4.0

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: pythonPackages.pytorch

Partial log (click to expand)

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
CUDA not available, skipping tests
Running test_nn ...
Error: failed to parse the list of possible procesors in /sys/devices/system/cpu/possible
Error: failed to parse the list of present procesors in /sys/devices/system/cpu/present
building of '/nix/store/8jw0c9gcnx3flvmdka2vh3pravm11y28-python2.7-pytorch-0.4.0.drv' timed out after 3600 seconds
�[31;1merror:�[0m build of '/nix/store/8jw0c9gcnx3flvmdka2vh3pravm11y28-python2.7-pytorch-0.4.0.drv' failed

@andersk
Copy link
Contributor Author

andersk commented May 14, 2018

That aarch64 failure is a timeout; it does take quite a while to build.

@teh
Copy link
Contributor

teh commented May 14, 2018

How would you feel about removing aarch64 as a supported platform? LGTM otherwise, thanks!

@andersk
Copy link
Contributor Author

andersk commented May 14, 2018

@teh As far as I’m aware, it should work fine on aarch64, as long as you wait for it to build. Do we generally remove platforms just for taking more than an hour to build?

@nlewo
Copy link
Member

nlewo commented May 15, 2018

@andersk I think it's fine with aarch64. Thanks

@nlewo nlewo merged commit 640b635 into NixOS:master May 15, 2018
@andersk andersk deleted the pytorch branch December 10, 2019 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andersk @nlewo @GrahamcOfBorg @teh