Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sasview: fix build #40433

Merged
merged 1 commit into from May 13, 2018
Merged

sasview: fix build #40433

merged 1 commit into from May 13, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented May 13, 2018 •
edited

Motivation for this change

The package breaks currently breaks with the following message:

fixed-output derivation produced path '/nix/store/5dh1mdj027ad8sprk12fqa5h5bpdxs5n-sasview' with sha256 hash '12k1w4yq1mzjxcp2cqb562c7cbwzhi54rsbmgi0fax0i1660q167' instead of the expected hash '05la54wwzzlkhmj8vkr0bvzagyib6z6mgwqbddzjs5y1wd48vpcx'

To fix the build the following changes were applied:

  • Switched to latest master for now as the older releases have a broken
    py.test configuration and altering hashes.

  • Added checkPhase which invokes py.test directly and drops
    duplicated files from dist/tmpbuild.

  • Rebased the patches pyparsing-fix.patch and local_config.patch for
    the latest master revision.

Additionally refer to the discussion in #40381 for further reference.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member Author

Ma27 commented May 13, 2018

/cc @xeji @rprospero

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sasview

Partial log (click to expand)

test/sasinvariant/test/utest_data_handling.py ......................     [ 91%]
test/sasinvariant/test/utest_use_cases.py ...............                [100%]

=============================== warnings summary ===============================
test/sasdataloader/test/utest_generic_file_reader_class.py::TestFileReader
  cannot collect test class 'TestFileReader' because it has a __init__ constructor

-- Docs: http://doc.pytest.org/en/latest/warnings.html
=================== 170 passed, 1 warnings in 11.06 seconds ====================
/nix/store/b3glnyirlpclaakla2282y09lpkmr39i-sasview-unstable-2018-05-05

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: sasview

Partial log (click to expand)

                 from memoryviewattrs.cpp:580:
/nix/store/9ib9731m2av0dxpnj36gdwr48c6qmzvd-python2.7-numpy-1.14.2/lib/python2.7/site-packages/numpy/core/include/numpy/npy_1_7_deprecated_api.h:15:2: warning: #warning "Using deprecated NumPy API, disable it by " "#defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-Wcpp]
 #warning "Using deprecated NumPy API, disable it by " \
  ^~~~~~~
acquired default
acquired Global_A
building of '/nix/store/57yvs2z6ji0i3j7hmap49l1irn9kfc79-python2.7-Cython-0.28.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/q71h6yqffh2a9pl7ifsf21yhcn6h1dqp-python2.7-h5py-2.7.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/gybldkhspfw3yhp8k7mq51a9x33drpw4-sasview-unstable-2018-05-05.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/gybldkhspfw3yhp8k7mq51a9x33drpw4-sasview-unstable-2018-05-05.drv' failed

@Ma27
Copy link
Member Author

Ma27 commented May 13, 2018

not an aarch64 user, should be simply restrict the build platforms?

@xeji
Copy link
Contributor

xeji commented May 13, 2018 via email

@Ma27
Copy link
Member Author

Ma27 commented May 13, 2018

@xeji neither x86 nor aarch64 built previously according to Hydra:

It appears to be a dependency failure (sasmodels and the broken fixed-output derivation), but we won't break anything, so I'd go for restricting.
In case anybody needs sasview on aarch64 and has the resources to sufficiently fix and test it he can go for it, right?

@xeji
Copy link
Contributor

xeji commented May 13, 2018 via email

@Ma27
sasview: fix build
856ab17 
The package breaks currently breaks with the following message:

```
fixed-output derivation produced path '/nix/store/5dh1mdj027ad8sprk12fqa5h5bpdxs5n-sasview' with sha256 hash '12k1w4yq1mzjxcp2cqb562c7cbwzhi54rsbmgi0fax0i1660q167' instead of the expected hash '05la54wwzzlkhmj8vkr0bvzagyib6z6mgwqbddzjs5y1wd48vpcx'
```

To fix the build the following changes were applied:

* Switched to latest master for now as the older releases have a broken
  `py.test` configuration and altering hashes.

* Added `checkPhase` which invokes `py.test` directly and drops
  duplicated files from `dist/tmpbuild`.

* Rebased the patches `pyparsing-fix.patch` and `local_config.patch` for
  the latest master revision.

Additionally refer to the discussion in NixOS#40381 for further reference.
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sasview

Partial log (click to expand)

test/sasinvariant/test/utest_data_handling.py ......................     [ 91%]
test/sasinvariant/test/utest_use_cases.py ...............                [100%]

=============================== warnings summary ===============================
test/sasdataloader/test/utest_generic_file_reader_class.py::TestFileReader
  cannot collect test class 'TestFileReader' because it has a __init__ constructor

-- Docs: http://doc.pytest.org/en/latest/warnings.html
==================== 170 passed, 1 warnings in 8.07 seconds ====================
/nix/store/b3glnyirlpclaakla2282y09lpkmr39i-sasview-unstable-2018-05-05

@xeji xeji merged commit be53a0f into NixOS:master May 13, 2018
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: sasview

Partial log (click to expand)

                 from memoryviewattrs.cpp:580:
/nix/store/9ib9731m2av0dxpnj36gdwr48c6qmzvd-python2.7-numpy-1.14.2/lib/python2.7/site-packages/numpy/core/include/numpy/npy_1_7_deprecated_api.h:15:2: warning: #warning "Using deprecated NumPy API, disable it by " "#defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-Wcpp]
 #warning "Using deprecated NumPy API, disable it by " \
  ^~~~~~~
acquired default
acquired Global_A
building of '/nix/store/57yvs2z6ji0i3j7hmap49l1irn9kfc79-python2.7-Cython-0.28.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/q71h6yqffh2a9pl7ifsf21yhcn6h1dqp-python2.7-h5py-2.7.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/gybldkhspfw3yhp8k7mq51a9x33drpw4-sasview-unstable-2018-05-05.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/gybldkhspfw3yhp8k7mq51a9x33drpw4-sasview-unstable-2018-05-05.drv' failed

@Ma27 Ma27 deleted the fix-sasview branch May 13, 2018 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ma27 @GrahamcOfBorg @xeji @FRidh