Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libinput: 1.10.0 -> 1.10.6 #40451

Closed
wants to merge 1 commit into from
Closed

Conversation

jcrben
Copy link
Contributor

@jcrben jcrben commented May 13, 2018

Motivation for this change

UX improvements esp. for trackpoints and touchpads

Note: nix-shell -p --run "nox-review-wip" locked up my computer for a while (walked away) and then failed, gist at https://gist.github.com/jcrben/b16aefebafd3921dd27a44eb3c72362c - I wonder if the lockup might've caused an issue ('GC Warning: Repeated allocation of very large block (appr. size 217088): May lead to memory leak and poor performance')

Technically I built 1.10.5 from scratch and that succeeded. 1.10.6 just has some tweaks for hardware I don't have, but I will build it to be safe esp given this nox-review.

Background:

This seems better for my thinkpad t460s altho still not as good as my macbook running darwin. Did not test on any other hardware.

cc @codyopel @wkennington @ryantm

PS: noticed the last update was semi-automated, curious about how that works

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

UX improvements esp. for trackpoints and touchpads
@xeji
Copy link
Contributor

xeji commented May 13, 2018

libinput was bumped to 1.10.3 in #38202 , which was merged to staging because it's a mass rebuild. Please rebase your change on staging and open a new PR (changing base of an open PR to staging is likely to create a mess).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants