Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
UX improvements esp. for trackpoints and touchpads
Note:
nix-shell -p --run "nox-review-wip"
locked up my computer for a while (walked away) and then failed, gist at https://gist.github.com/jcrben/b16aefebafd3921dd27a44eb3c72362c - I wonder if the lockup might've caused an issue ('GC Warning: Repeated allocation of very large block (appr. size 217088): May lead to memory leak and poor performance')Technically I built 1.10.5 from scratch and that succeeded. 1.10.6 just has some tweaks for hardware I don't have, but I will build it to be safe esp given this nox-review.
Background:
This seems better for my thinkpad t460s altho still not as good as my macbook running darwin. Did not test on any other hardware.
cc @codyopel @wkennington @ryantm
PS: noticed the last update was semi-automated, curious about how that works
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)