haskell-generic-builder: Add extra framework dirs #40442
Conversation
Ericson2314
force-pushed
the
cabal-frameworks
branch
from
310ea97
to
cc6cbfd
Compare
| @@ -242,6 +242,9 @@ stdenv.mkDerivation ({ | |||
| if [ -d "$p/lib" ]; then | |||
| configureFlags+=" --extra-lib-dirs=$p/lib" | |||
| fi | |||
| if [[ -d "$p/Library/Frameworks" ]]; then | |||
There was a problem hiding this comment.
So sometimes this is just in /Frameworks IIRC
There was a problem hiding this comment.
Then cc-wrapper needs to be changed too :D.
There was a problem hiding this comment.
Which is preferred? I think Library & System are often used by Apple kind if like usr is on Linux. At least it seems like we can move them to all be /Frameworks
There was a problem hiding this comment.
I have no idea. CC @NixOS/darwin-maintainers. I think it best we merge this and then sort out all that later. But thanks for making me aware :).
Just like with the other `--extra-*` flags, cc/ld-wrapper already handles this, but we need to make Cabal aware so that the haskell builds have the correct metadata.
Ericson2314
force-pushed
the
cabal-frameworks
branch
from
cc6cbfd
to
c6f742b
Compare
|
It's been a few days, and I very much need to do more work that depends on this. I'll merge, not rebase, to staging so @peti can merge the same commit to |
Motivation for this change
Just like with the other
--extra-*flags, cc/ld-wrapper already handles this, but we need to make Cabal aware so that the haskell builds have the correct metadata.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)CC @ElvishJerricco