Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubiks: fix build #39608

Merged
merged 1 commit into from Apr 27, 2018
Merged

rubiks: fix build #39608

merged 1 commit into from Apr 27, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Apr 27, 2018 •
edited

Motivation for this change

After implementing a suggestion from my rubiks-init PR (#38803), I failed to realize that nix build rubiks now actually produces an empty directory. Probably I only checked for build failure when making that change, without sanity-checking the contents of result.

This fixes that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Apr 27, 2018

@GrahamcOfBorg build rubiks

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rubiks

Partial log (click to expand)

shrinking /nix/store/x3vmsax3pyl151v857iqsnhpnrjwdv5v-rubiks-20070912/bin/cubex
shrinking /nix/store/x3vmsax3pyl151v857iqsnhpnrjwdv5v-rubiks-20070912/bin/mcube
shrinking /nix/store/x3vmsax3pyl151v857iqsnhpnrjwdv5v-rubiks-20070912/bin/cu2
shrinking /nix/store/x3vmsax3pyl151v857iqsnhpnrjwdv5v-rubiks-20070912/bin/dikcube
shrinking /nix/store/x3vmsax3pyl151v857iqsnhpnrjwdv5v-rubiks-20070912/bin/size222
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/x3vmsax3pyl151v857iqsnhpnrjwdv5v-rubiks-20070912/bin
patching script interpreter paths in /nix/store/x3vmsax3pyl151v857iqsnhpnrjwdv5v-rubiks-20070912
checking for references to /build in /nix/store/x3vmsax3pyl151v857iqsnhpnrjwdv5v-rubiks-20070912...
/nix/store/x3vmsax3pyl151v857iqsnhpnrjwdv5v-rubiks-20070912

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: rubiks

Partial log (click to expand)

shrinking /nix/store/b1jqwv1hz7zyw93adxqzvk7nkq26cbmv-rubiks-20070912/bin/dikcube
shrinking /nix/store/b1jqwv1hz7zyw93adxqzvk7nkq26cbmv-rubiks-20070912/bin/cu2
shrinking /nix/store/b1jqwv1hz7zyw93adxqzvk7nkq26cbmv-rubiks-20070912/bin/mcube
shrinking /nix/store/b1jqwv1hz7zyw93adxqzvk7nkq26cbmv-rubiks-20070912/bin/cubex
shrinking /nix/store/b1jqwv1hz7zyw93adxqzvk7nkq26cbmv-rubiks-20070912/bin/optimal
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/b1jqwv1hz7zyw93adxqzvk7nkq26cbmv-rubiks-20070912/bin
patching script interpreter paths in /nix/store/b1jqwv1hz7zyw93adxqzvk7nkq26cbmv-rubiks-20070912
checking for references to /build in /nix/store/b1jqwv1hz7zyw93adxqzvk7nkq26cbmv-rubiks-20070912...
/nix/store/b1jqwv1hz7zyw93adxqzvk7nkq26cbmv-rubiks-20070912

@xeji xeji merged commit ab6b47d into NixOS:master Apr 27, 2018
@timokau timokau deleted the rubiks-fix branch April 27, 2018 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @xeji @GrahamcOfBorg