To summary various discussions from the past. There are two cloning tools, which currently behave like this:

• Depot window with cloning tool:
  • Opens the window of the new vehicle.
  • Disable the tool.
• Vehicle window clone button when vehicle is inside depot:
  • Open the window of the new vehicle when copy-cloning.
  • Do not open the window of the new vehicle when share-cloning.

The behaviour targets these use-cases:

• When you copy-clone a vehicle, you use the source vehicle as a template, but want to adjust it. I.e. open the vehicle window.
• When you share-clone a vehicle, you do not want to make any adjustments. I.e. do not clutter the screen with vehicle windows.

So with this in mind, at least in the copy-clone case the depot tool should be deactivated after usage.
The share-clone case is probably fine to change.

While the behaviour appears inconsistent, assuming the player knows about shared orders, it is the most convenient behaviour.

Suggested behaviour:

• Depot clone tool stays active when share-cloning. Vehicle window is not opened.
• Depot clone tool disables when copy-cloning. Vehicle window is opened.

Other opinions?

@frosch123 It's better as it is now imo. When you share-clone from depot you need to click vehicle in the veiwport which can be quite tricky if it's moving or there are other vehicles around. It's way easier to find it once and just spam clone in vehicle window than catching them in the viewport each time. I even have depot clone and vehicle clone binded to same hotkey(Ctrl-O) so if I need spam-clone some vehicles I just go Ctrl-O-click-O-O-O-O-O.

On a second thought I guess it won't be that hard to spam-click it in the viewport. While hotkey scheme I'm not even sure is possible in vanilla and it can be readjusted anyway. So it may be better overall since it will avoid opening redundant vehicle window.

@frosch123 Deactivating it when copy-cloning kind of makes sense. At the same I don't think having the clone tool active when editing a vehicle is a problem, because I don't think it changes any of the behaviour of editing a vehicle (and it might be easier to just keep the clone tool behaviour the same)?
I'd be happy to change it though! (It's mainly useful for for share-cloning)

When changing the behaviour I would prefer to make the two clone buttons behave the same.
So, keep-active when share-cloning. Disable when copy-cloning.

Just a friendly poke to see if you are still up for this task? We would love to include it .. seems it is nearly there :D

Whoops. Forgot about it. I'll finish it up.

I think this implements the changes @frosch123 suggested.

Thanks @nielsmh!