Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cysignals: 1.6.9 -> 1.7.1 #39614

Merged
merged 1 commit into from Apr 27, 2018
Merged

pythonPackages.cysignals: 1.6.9 -> 1.7.1 #39614

merged 1 commit into from Apr 27, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Apr 27, 2018 •
edited

Motivation for this change

Version bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from FRidh as a code owner April 27, 2018 16:44
dotlambda
dotlambda requested changes Apr 27, 2018
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please prepend the commit message with pythonPackages.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.cysignals python3.pkgs.cysignals

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.cysignals, python3.pkgs.cysignals

Partial log (click to expand)

shrinking /nix/store/03qvzlyilfs9ydq6cndy0zs8hhrigb2b-python3.6-cysignals-1.7.1/lib/python3.6/site-packages/cysignals/signals.cpython-36m-x86_64-linux-gnu.so
shrinking /nix/store/03qvzlyilfs9ydq6cndy0zs8hhrigb2b-python3.6-cysignals-1.7.1/lib/python3.6/site-packages/cysignals/pysignals.cpython-36m-x86_64-linux-gnu.so
shrinking /nix/store/03qvzlyilfs9ydq6cndy0zs8hhrigb2b-python3.6-cysignals-1.7.1/lib/python3.6/site-packages/cysignals/pselect.cpython-36m-x86_64-linux-gnu.so
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/03qvzlyilfs9ydq6cndy0zs8hhrigb2b-python3.6-cysignals-1.7.1/lib  /nix/store/03qvzlyilfs9ydq6cndy0zs8hhrigb2b-python3.6-cysignals-1.7.1/bin
patching script interpreter paths in /nix/store/03qvzlyilfs9ydq6cndy0zs8hhrigb2b-python3.6-cysignals-1.7.1
checking for references to /build in /nix/store/03qvzlyilfs9ydq6cndy0zs8hhrigb2b-python3.6-cysignals-1.7.1...
wrapping `/nix/store/03qvzlyilfs9ydq6cndy0zs8hhrigb2b-python3.6-cysignals-1.7.1/bin/cysignals-CSI'...
/nix/store/hvblkp4p283h7nsmsk4rziqj9svcblc2-python2.7-cysignals-1.7.1
/nix/store/03qvzlyilfs9ydq6cndy0zs8hhrigb2b-python3.6-cysignals-1.7.1

@dotlambda
Copy link
Member

Did they change anything which makes the tests pass?

@timokau
Copy link
Member Author

timokau commented Apr 27, 2018

No, unfortunately not. Sages gdb is still not on version 8.

@timokau
Copy link
Member Author

timokau commented Apr 27, 2018

Commit message fixed.

@dotlambda dotlambda changed the title cysignals: 1.6.9 -> 1.7.1 pythonPackages.cysignals: 1.6.9 -> 1.7.1 Apr 27, 2018
@dotlambda dotlambda merged commit d22ed1a into NixOS:master Apr 27, 2018
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python2.pkgs.cysignals, python3.pkgs.cysignals

Partial log (click to expand)

/nix/store/savp4vc8d7i9nmb7wcsdx3prakp37vgv-python2.7-numpy-1.14.2/lib/python2.7/site-packages/numpy/core/include/numpy/npy_1_7_deprecated_api.h:15:2: warning: #warning "Using deprecated NumPy API, disable it by " "#defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-Wcpp]
 #warning "Using deprecated NumPy API, disable it by " \
  ^~~~~~~
acquired default
acquired Global_A
building of '/nix/store/g9ccyb85m5kxbfb3gy26840d90qxsf9k-python2.7-Cython-0.28.1.drv' timed out after 3600 seconds
building of '/nix/store/l60jan1mgs2yd0lnkmsprzjapx4rynv9-python3.6-Cython-0.28.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/f2kg4k3168r7f9i6q7vz90vxqkq3g2yd-python2.7-cysignals-1.7.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/gjip6g1q3q32lp0r9r23dn924wgh67f3-python3.6-cysignals-1.7.1.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/f2kg4k3168r7f9i6q7vz90vxqkq3g2yd-python2.7-cysignals-1.7.1.drv', '/nix/store/gjip6g1q3q32lp0r9r23dn924wgh67f3-python3.6-cysignals-1.7.1.drv' failed

@timokau timokau deleted the cysignals-1.7.1 branch April 27, 2018 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @dotlambda @GrahamcOfBorg