Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: f13873f35aaf
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 900cec79a0aa
Choose a head ref
  • 12 commits
  • 8 files changed
  • 1 contributor

Commits on Apr 27, 2018

  1. lib/debug: add traceValFn, traceValSeqFn, traceValSeqNFn 

    Being able to modify the value on-the-fly before printing is very useful in
practice.
    @Profpatsch
    Profpatsch committed Apr 27, 2018
    Copy the full SHA
    a5f6cdf View commit details
    Browse the repository at this point in the history

  2. lib/debug: remove the deprecated strict function 

    The grace period was long enough.
    @Profpatsch
    Profpatsch committed Apr 27, 2018
    Copy the full SHA
    a455637 View commit details
    Browse the repository at this point in the history

  3. lib/debug: deprecate & modernize showVal 

    The code is re-implemented in terms of `generators.toPretty`, but is strictly
less general than `traceValSeqN`, so we deprecate it.
    @Profpatsch
    Profpatsch committed Apr 27, 2018
    Copy the full SHA
    a7fdd10 View commit details
    Browse the repository at this point in the history

  4. lib/debug: deprecate attrNamesToStr, traceXMLVal(Marked) 

    `attrNamesToStr` is very specific (and pretty trivial), so it doesn’t make sense
to have it in the library.
`traceXMLVal(Marked)` are just a builtin and `trace` and not very useful in
general (trace output should not be parsed anyway).
    @Profpatsch
    Profpatsch committed Apr 27, 2018
    Copy the full SHA
    7365671 View commit details
    Browse the repository at this point in the history

  5. lib/debug: deprecate traceValIfNot 

    The function is only used in exactly one module and overly specific (`c` must be
a true predicate for `x`, if not, a specific trace is called).
    @Profpatsch
    Profpatsch committed Apr 27, 2018
    Copy the full SHA
    562286a View commit details
    Browse the repository at this point in the history

  6. lib/debug: fix use-sites of deprecated debug functions

    @Profpatsch
    Profpatsch committed Apr 27, 2018
    Copy the full SHA
    b90104e View commit details
    Browse the repository at this point in the history

  7. lib/debug: deprecate addErrorContextToAttrs 

    The function isn’t used anywhere and `addErrorContext` is an undocumented
builtin.
The builtin is explicitely qualified at its two uses in the module system.
    @Profpatsch
    Profpatsch committed Apr 27, 2018
    Copy the full SHA
    fd54a94 View commit details
    Browse the repository at this point in the history

  8. lib/debug: deprecate traceCallXml 

    Incompletely documented, and a FIXME/bug that has been there for years.
    @Profpatsch
    Profpatsch committed Apr 27, 2018
    Copy the full SHA
    e49f40e View commit details
    Browse the repository at this point in the history

  9. lib/debug: document module & functions, prune imports

    @Profpatsch
    Profpatsch committed Apr 27, 2018
    Copy the full SHA
    5012c49 View commit details
    Browse the repository at this point in the history

  10. CODEOWNERS: add Profpatsch to lib/debug.nix 

    Reason: has overhauled the module quite substantially.
    @Profpatsch
    Profpatsch committed Apr 27, 2018
    Copy the full SHA
    0615661 View commit details
    Browse the repository at this point in the history

  11. docs: initial manual entry for lib/debug.nix 

    It is more of a stub for now, but at least points to the right file.
    @Profpatsch
    Profpatsch committed Apr 27, 2018
    Copy the full SHA
    21b87a7 View commit details
    Browse the repository at this point in the history

  12. lib/debug: add replacement instructions & release notes 

    for every deprecated function.
    @Profpatsch
    Profpatsch committed Apr 27, 2018
    Copy the full SHA
    900cec7 View commit details
    Browse the repository at this point in the history