-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Self-conflicts treated as actual conflicts at upgrade #2428
Comments
So uninstalling and reinstalling worked perfectly. |
Confirmed that the weird self-conflict is a factor. I installed (Not sure why the sunflare and config packages aren't listed there, since they're also checked for upgrade.) The self-conflict was added in KSP-CKAN/NetKAN#4541, but there's no explanation other than fixing #1870, which has a discussion that seems to be outdated now about SVE-HighResolution including Scatterer somehow. Current StockVisualEnhancements recommends Scatterer itself with no funny business. I think maybe one of these had |
Maybe a solution would be ignoring self-conflicts on updates? |
Well, first I'd like to get a better understanding of exactly how and why it breaks and whether this is in fact a recent problem. It's possible that this is highlighting some logic error deep within the relationship resolver, the fixing of which could improve general robustness. Or it's possible that the upgrade logic is tripping over itself somewhere along the line as it attempts to reconcile removing and installing the same identifier in one step. |
Confirmed the speculation about We probably can and should remove the self-conflict now, but preferably after fixing the problems it causes in the upgrade logic. |
This exception is being caught: Lines 604 to 610 in 29c8025
|
That's coming from here: CKAN/Core/Relationships/SanityChecker.cs Lines 43 to 49 in 29c8025
So it looks like a regression of the "Mods are allowed to conflict with themselves" behavior. |
OK, it looks like what's happening is that CKAN/Core/Relationships/SanityChecker.cs Lines 71 to 78 in b75a450
In effect, the weirdness of this aspect of upgrading was masked by #2325, and fixing that issue brought it forward. I see two ways to fix it:
The first option would be simpler and safer, but the second would be cleaner in terms of how it "should" work. |
It sounds like we need a more robust model of a "change" that involves "(remove [a,b,c,..]) and (add [x,y,x,...])" and stop trying to consider "upgrade" as a unique change type. |
Experienced as reported in first post. Only seen this concerning the mods "Scatterer" and "VesselMover Continued". |
Background
CKAN Version:
v1.25.1
KSP Version:
v1.4.2.2110
Operating System:
Windows10 64bit
Have you made any manual changes to your GameData folder (i.e., not via CKAN)?
No
Problem
What steps did you take in CKAN?
a) Marked all mods to update via
Add available updates
-button and clicked applyb) Marked all mods manually (not via button)
What did you expect to happen?
a) Mods to update show in changset tab
b)
Apply changes
-button gets activatedWhat happened instead?
a) Mods not showing in changeset tab, clicking apply does nothing
b)
Apply changes
-button doesn't get activatedScreenshots:


a) Selecting all via button:
then clicking apply (no changes listed):
b) Selecting manually (button won't get activated):

Thoughts
This might either be because scatterer has its new version listed as conflict:

or the only change since v1.25.0 affecting anything in that area I know would be #2425Scratch that, I can't imagine how refreshing the row could cause this.
The text was updated successfully, but these errors were encountered: