kcov: 34 -> 35 #39624
Merged
kcov: 34 -> 35 #39624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the maintainer currently in `meta.maintainers` appears to not have touched the package since 2015, I've also added myself there.
|
Success on x86_64-linux (full log) Attempted: kcov Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: kcov Partial log (click to expand)
|
Apparently, without this patch `NT_PRSTATUS` is not found. So the patch adds the include apparently necessary. `NT_PRSTATUS` is also defined in `<linux/ptrace.h>`, which would likely have been a better name, were it not in the `linux/` directory, which is a priori not stable. The need to do that is kind of weird (the change was introduced in [1], and fedora apparently didn't need this additional import), but I'll try to upstream it. [1] SimonKagstrom/kcov#239
Mic92
reviewed
Apr 27, 2018
| }; | ||
|
|
||
| preConfigure = "patchShebangs src/bin-to-c-source.py"; | ||
| nativeBuildInputs = [ cmake pkgconfig ]; | ||
|
|
||
| buildInputs = [ zlib curl elfutils python libiberty libopcodes ]; | ||
|
|
||
| patches = [ ./aarch64_nt_prstatus.patch ]; |
There was a problem hiding this comment.
Look useful. Is this pull request included in the next upstream version or does it come from a pull request?
There was a problem hiding this comment.
I'm going to PR it to the next upstream version if it does manage the ofborg build :)
There was a problem hiding this comment.
Just opened SimonKagstrom/kcov#243 :)
|
@GrahamcOfBorg build kcov |
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: kcov Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: kcov Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: kcov Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: kcov Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: kcov Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the maintainer currently in
meta.maintainersappears to not havetouched the package since 2015, I've also added myself there.
cc @FlorentBecker
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)