Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Don't show Android edit dialog when tapping read-only field (#7337)
* Don't show Android edit dialog when tapping read-only field

From Lua API, "If the name is empty the textarea is readonly."
  • Loading branch information
srifqi authored and nerzhul committed May 15, 2018
1 parent a1598e1 commit 2f34797
Showing 1 changed file with 11 additions and 9 deletions.
20 changes: 11 additions & 9 deletions src/gui/guiFormSpecMenu.cpp
Expand Up @@ -3026,29 +3026,31 @@ bool GUIFormSpecMenu::preprocessEvent(const SEvent& event)
core::position2d<s32>(event.MouseInput.X, event.MouseInput.Y));
if ((hovered) && (hovered->getType() == irr::gui::EGUIET_EDIT_BOX)) {
bool retval = hovered->OnEvent(event);
if (retval) {
if (retval)
Environment->setFocus(hovered);
}
m_JavaDialogFieldName = getNameByID(hovered->getID());

std::string field_name = getNameByID(hovered->getID());
/* read-only field */
if (field_name.empty())
return retval;

m_JavaDialogFieldName = field_name;
std::string message = gettext("Enter ");
std::string label = wide_to_utf8(getLabelByID(hovered->getID()));
if (label == "") {
if (label.empty())
label = "text";
}
message += gettext(label) + ":";

/* single line text input */
int type = 2;

/* multi line text input */
if (((gui::IGUIEditBox*) hovered)->isMultiLineEnabled()) {
if (((gui::IGUIEditBox*) hovered)->isMultiLineEnabled())
type = 1;
}

/* passwords are always single line */
if (((gui::IGUIEditBox*) hovered)->isPasswordBox()) {
if (((gui::IGUIEditBox*) hovered)->isPasswordBox())
type = 3;
}

porting::showInputDialog(gettext("ok"), "",
wide_to_utf8(((gui::IGUIEditBox*) hovered)->getText()),
Expand Down

0 comments on commit 2f34797

Please sign in to comment.