Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rPackages.JuniperKernel: fix non-Darwin build #40543

Merged
merged 1 commit into from May 15, 2018
Merged

rPackages.JuniperKernel: fix non-Darwin build #40543

merged 1 commit into from May 15, 2018

Conversation

mnacamura
Copy link
Contributor

Motivation for this change

This fixes JuniperKernel on non-Darwin platforms.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mnacamura mnacamura requested a review from peti as a code owner May 15, 2018 08:50
@matthewbauer matthewbauer merged commit 656e4d6 into NixOS:master May 15, 2018
@mnacamura mnacamura deleted the darwin-juniper branch May 16, 2018 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mnacamura @matthewbauer @GrahamcOfBorg