add XPS 13 (9360) #58
Conversation
dell/xps/13-9360/default.nix
Outdated
| efi.canTouchEfiVariables = lib.mkDefault true; | ||
| }; | ||
|
|
||
| kernelPackages = lib.mkDefault pkgs.linuxPackages_latest; |
There was a problem hiding this comment.
Does it only work with the latest kernel? (Current LTS kernel is 4.14.x)
There was a problem hiding this comment.
everything higher than 4.11 should work without kernel patches, but not all of them work as well as others. 4.14.x should be fine, but I haven't tested that in forever.
Is https://patchwork.kernel.org/patch/9676073/ in 4.14?
edit: yes.
dell/xps/13-9360/default.nix
Outdated
| i18n.consoleFont = "latarcyrheb-sun32"; | ||
|
|
||
| # touchpad | ||
| services.xserver.libinput.enable = lib.mkDefault true; |
There was a problem hiding this comment.
dell/xps/13-9360/default.nix
Outdated
| # touchpad | ||
| services.xserver.libinput.enable = lib.mkDefault true; | ||
|
|
||
| networking.wireless.enable = lib.mkDefault true; |
There was a problem hiding this comment.
dell/xps/13-9360/default.nix
Outdated
| services.xserver.libinput.enable = lib.mkDefault true; | ||
|
|
||
| networking.wireless.enable = lib.mkDefault true; | ||
| hardware.bluetooth.enable = lib.mkDefault true; |
There was a problem hiding this comment.
This module should really be called services.bluez :-)
Bluetooth works without that, say, in GNOME.
dell/xps/13-9360/default.nix
Outdated
| # touchpad goes over i2c | ||
| blacklistedKernelModules = [ "psmouse" ]; | ||
|
|
||
| kernelParams = [ "i915.enable_fbc=1" "i915.enable_psr=2" ]; |
There was a problem hiding this comment.
This should probably be moved to common/cpu/intel/kaby-lake/default.nix.
dell/xps/13-9360/default.nix
Outdated
| ../../../common/cpu/intel | ||
| ../../../common/pc/laptop | ||
| ]; | ||
| boot.kernelModules = ["kvm-intel"]; # should this be in common/cpu/intel? |
There was a problem hiding this comment.
The policy up until now was to not include options that are generated by nixos-generate-config.
| target = "QCA6174"; | ||
|
|
||
| src = fetchurl { | ||
| url = "https://github.com/kvalo/ath10k-firmware/raw/master/${target}/hw3.0/${branch}/firmware-6.bin_RM.${version}-QCARMSWP-1"; |
There was a problem hiding this comment.
This hash will break if https://github.com/kvalo/ath10k-firmware is updated. It is better to reference a concrete commit.
There was a problem hiding this comment.
Also we can add this to nixpkgs directly.
There was a problem hiding this comment.
Oh, right. Didn't notice that.
No description provided.