Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i7z: do not build the GUI by default #40540

Merged
merged 1 commit into from May 16, 2018
Merged

i7z: do not build the GUI by default #40540

merged 1 commit into from May 16, 2018

Conversation

peterhoeg
Copy link
Member

Motivation for this change

I realized that i7z would pull in gtk2 and qt4 due to its GUI, so make that optional.

Also, the GUI is based on qt4 so we probably don't want that by default anyway.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member Author

Cc @bluescreen303

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: i7z

Partial log (click to expand)

     asm volatile ("mov %%ebx, %%edi;" // save ebx (for PIC)
     ^~~
helper_functions.c:96:5: error: output number 1 not directly addressable
helper_functions.c:96:5: error: unknown register name 'edi' in 'asm'
     asm volatile ("mov %%ebx, %%edi;" // save ebx (for PIC)
     ^~~
helper_functions.c:96:5: error: output number 1 not directly addressable
make: *** [<builtin>: helper_functions.o] Error 1
builder for '/nix/store/1r4k62rqhgzpg05g737si728b8amf71j-i7z-0.27.2.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/1r4k62rqhgzpg05g737si728b8amf71j-i7z-0.27.2.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: i7z

Partial log (click to expand)

install -m 0644 README.txt put_cores_offline.sh put_cores_online.sh MAKEDEV-cpuid-msr /nix/store/hraw23hp60gwxli1d58dfybk47x1g6wq-i7z-0.27.2/share/doc/i7z/
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hraw23hp60gwxli1d58dfybk47x1g6wq-i7z-0.27.2
shrinking /nix/store/hraw23hp60gwxli1d58dfybk47x1g6wq-i7z-0.27.2/bin/i7z
gzipping man pages under /nix/store/hraw23hp60gwxli1d58dfybk47x1g6wq-i7z-0.27.2/share/man/
/nix/store/hraw23hp60gwxli1d58dfybk47x1g6wq-i7z-0.27.2
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hraw23hp60gwxli1d58dfybk47x1g6wq-i7z-0.27.2/bin
patching script interpreter paths in /nix/store/hraw23hp60gwxli1d58dfybk47x1g6wq-i7z-0.27.2
checking for references to /build in /nix/store/hraw23hp60gwxli1d58dfybk47x1g6wq-i7z-0.27.2...

@peterhoeg
Copy link
Member Author

#33248 @yegortimoshenko

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: i7z

Partial log (click to expand)

install -m 0644 README.txt put_cores_offline.sh put_cores_online.sh MAKEDEV-cpuid-msr /nix/store/hraw23hp60gwxli1d58dfybk47x1g6wq-i7z-0.27.2/share/doc/i7z/
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hraw23hp60gwxli1d58dfybk47x1g6wq-i7z-0.27.2
shrinking /nix/store/hraw23hp60gwxli1d58dfybk47x1g6wq-i7z-0.27.2/bin/i7z
gzipping man pages under /nix/store/hraw23hp60gwxli1d58dfybk47x1g6wq-i7z-0.27.2/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hraw23hp60gwxli1d58dfybk47x1g6wq-i7z-0.27.2/bin
patching script interpreter paths in /nix/store/hraw23hp60gwxli1d58dfybk47x1g6wq-i7z-0.27.2
checking for references to /build in /nix/store/hraw23hp60gwxli1d58dfybk47x1g6wq-i7z-0.27.2...
/nix/store/hraw23hp60gwxli1d58dfybk47x1g6wq-i7z-0.27.2

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: i7z

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@lukateras lukateras merged commit 7d842f3 into NixOS:master May 16, 2018
@peterhoeg peterhoeg deleted the f/i7z branch October 8, 2018 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukateras lukateras lukateras approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @GrahamcOfBorg @lukateras