Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texlive-bin: fix build by using updated poppler patch #40180

Closed
wants to merge 1 commit into from
Closed

texlive-bin: fix build by using updated poppler patch #40180

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 8, 2018 •
edited

Build currently fails, and quite a lot of thigns depend on this.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented May 8, 2018

Using newer version of patch we were already using, FWIW.

We may wish to grab something like this combined patch from LFS but for now fixing the build is a good first step :).

@dtzWill dtzWill requested a review from jtojnar May 8, 2018 16:24
@dtzWill
Copy link
Member Author

dtzWill commented May 8, 2018

Whoops, this might not fix the build--sorry.

(borg's eval failure appears unrelated, FWIW)

@dtzWill
Copy link
Member Author

dtzWill commented May 8, 2018

Nevermind, I can't chase this down now. But hopefully someone else takes a look?

@dtzWill dtzWill closed this May 8, 2018
@jtojnar
Copy link
Contributor

jtojnar commented May 8, 2018 •
edited

Arch has newer version of texlive-bin. I tried applying both patches but it still does not compile. We should probably update texlive-bin.

cc @vcunat, @veprbl

@veprbl
Copy link
Member

veprbl commented May 8, 2018

Can you provide more explanations about what is broken?
Hydra has texlive.bin for darwin on master.

@jtojnar
Copy link
Contributor

jtojnar commented May 8, 2018

@veprbl this is on staging (#39742)

@xeji
Copy link
Contributor

xeji commented May 8, 2018

I'll try bumping to texlive 2018, which is supposed to work with poppler 0.64

@xeji
Copy link
Contributor

xeji commented May 8, 2018

No luck with this updated patch and a simple bump of texlive.bin to 2018, so I'll revert the poppler bump on staging for now.

@vcunat
Copy link
Member

vcunat commented May 10, 2018

Updating texlive might need lots of work. We could (temporarily) use texlive with older poppler.

@xeji xeji mentioned this pull request May 11, 2018
Merged
xeji added a commit that referenced this pull request May 12, 2018
@xeji
poppler_min: pin to poppler_0_61
108cf05 
poppler_min is only used by texlive.bin, which doesn't build
with poppler 0.64 and blocked the update poppler 0.63->0.64.
Pin to poppler_0_61 (which we currently need for libreoffice)
so we don't have to keep 0_63 as a third version.
See discussion in #40327 and #40180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @jtojnar @veprbl @xeji @vcunat