squashfsTools: apply reproducibility patches #40175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without these patches, the output of mksquashfs is not reproducible. The patches are taken from https://github.com/squashfskit/squashfskit, a fork of squashfs-tools, licensed under the GPL2 or later like squashfs-tools itself.
I think it would definitely be helpful for you to add yourself as maintainer. It's not as official as other distros, you will probably just be pinged on updates & stuff. If you could just keep track of these patches and updating them when newer versions of squashfs-tools comes out. |
I am adding myself as maintainer here for lack of a better candidate, but I am not experienced with Nix, and I am not a squashfs expert either.
ruuda
force-pushed
the
reproducible-squashfs
branch
from
00461b1
to
f0353d4
Compare
|
Okay, I added myself as a maintainer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Currently, the output of
mksquashfsis not reproducible. With these patches it is. See #40144 for the full details.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)I tested this change using the reproduction steps from #40144. With this change, the squashfs image is reproducible without the override workaround.
This does affect the NixOS iso and netboot images, which depend on
squashfsTools. Could there be any issues there? From the diffs of my own image, there were only a few bytes that differed in the non-reproducible version, but I haven’t diffed the reproducible version against one of the non-reproducible ones.The contributing guidelines say to also set the
maintainersfield. I can volunteer to be a maintainer, but I’ve only used Nix seriously in the past 48 hours and I am not an expert onsquashfseither, so if a more qualified person would like to be a maintainer please speak up.