Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

singularity: 2.4.6 -> 2.5.1 #40172

Merged
merged 1 commit into from May 8, 2018
Merged

singularity: 2.4.6 -> 2.5.1 #40172

merged 1 commit into from May 8, 2018

Conversation

scalavision
Copy link
Contributor

@scalavision scalavision commented May 8, 2018 •
edited

Motivation for this change

There is a severe security issue in the 2.4 version of Singularity. This version fixes the issue. I am totally new to Nix and Nixos, but I built it locally and it seems to work. I have no idea how to continue further than creating this PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ikervagyok
Copy link
Contributor

Maybe check these boxes:

  • built on nixos
  • ran all executables
  • fits contributing.md

Otherwise this should be all you need to do for most (simple) PRs.

@xeji
Copy link
Contributor

xeji commented May 8, 2018

@GrahamcOfBorg build singularity

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: singularity

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: singularity

Partial log (click to expand)

/nix/store/p86wvvv02m6cr84lbf9dz05y34wm5rpp-singularity-2.5.1/libexec/singularity/bootstrap-scripts/deffile-driver-localimage.sh: interpreter directive changed from "/bin/bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
/nix/store/p86wvvv02m6cr84lbf9dz05y34wm5rpp-singularity-2.5.1/libexec/singularity/bootstrap-scripts/deffile-driver-docker.sh: interpreter directive changed from "/bin/bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
/nix/store/p86wvvv02m6cr84lbf9dz05y34wm5rpp-singularity-2.5.1/libexec/singularity/bootstrap-scripts/deffile-driver-debootstrap.sh: interpreter directive changed from "/bin/bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
/nix/store/p86wvvv02m6cr84lbf9dz05y34wm5rpp-singularity-2.5.1/libexec/singularity/bootstrap-scripts/deffile-driver-busybox.sh: interpreter directive changed from "/bin/bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
/nix/store/p86wvvv02m6cr84lbf9dz05y34wm5rpp-singularity-2.5.1/libexec/singularity/bootstrap-scripts/deffile-driver-arch.sh: interpreter directive changed from "/bin/bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
/nix/store/p86wvvv02m6cr84lbf9dz05y34wm5rpp-singularity-2.5.1/libexec/singularity/bootstrap-scripts/checks.sh: interpreter directive changed from "/bin/bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
/nix/store/p86wvvv02m6cr84lbf9dz05y34wm5rpp-singularity-2.5.1/libexec/singularity/bootstrap-scripts/functions: interpreter directive changed from "/bin/bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
/nix/store/p86wvvv02m6cr84lbf9dz05y34wm5rpp-singularity-2.5.1/bin/run-singularity: interpreter directive changed from "/bin/sh" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh"
/nix/store/p86wvvv02m6cr84lbf9dz05y34wm5rpp-singularity-2.5.1/bin/singularity: interpreter directive changed from "/bin/bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
/nix/store/p86wvvv02m6cr84lbf9dz05y34wm5rpp-singularity-2.5.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: singularity

Partial log (click to expand)

/nix/store/99k5dka257hf84cndg3n0hgwj53rin84-singularity-2.5.1/libexec/singularity/cli/image.export.exec: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/99k5dka257hf84cndg3n0hgwj53rin84-singularity-2.5.1/libexec/singularity/helpers/image.sh: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/99k5dka257hf84cndg3n0hgwj53rin84-singularity-2.5.1/libexec/singularity/helpers/apps/list.sh: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/99k5dka257hf84cndg3n0hgwj53rin84-singularity-2.5.1/libexec/singularity/helpers/inspect.sh: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/99k5dka257hf84cndg3n0hgwj53rin84-singularity-2.5.1/libexec/singularity/helpers/check.sh: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/99k5dka257hf84cndg3n0hgwj53rin84-singularity-2.5.1/libexec/singularity/helpers/help.sh: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/99k5dka257hf84cndg3n0hgwj53rin84-singularity-2.5.1/libexec/singularity/image-handler.sh: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/99k5dka257hf84cndg3n0hgwj53rin84-singularity-2.5.1/bin/singularity: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/99k5dka257hf84cndg3n0hgwj53rin84-singularity-2.5.1/bin/run-singularity: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/99k5dka257hf84cndg3n0hgwj53rin84-singularity-2.5.1

@xeji xeji merged commit e7f3dab into NixOS:master May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@scalavision @ikervagyok @xeji @GrahamcOfBorg @Janik-Haag