MBS-9704: Skip checking credentials twice for WS #666
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`WS::2 'authenticate'` is used to authenticate user from credentials and to check authorization scope. Calling it twice was calling `Catalyst 'authenticate'` twice in a row which is not supposed to happen, thus returning 400 Bad Request error. This patch skips authenticating from credentials again if user already exists, that is, it has already been successfully authenticated from credentials. `WS::2 'authenticate'` still checks authorization scope.
mwiencek
approved these changes
May 11, 2018
reosarevok
added a commit
to reosarevok/musicbrainz-server
that referenced
this pull request
Feb 28, 2025
This uses the appropriate SVG icon from FontAwesome Free, which seems like a pretty decent option, but filled in metabrainz#666 grey. The 16px CSS setting for imgs inside 'buttons' is 15 years old or so and I'm not sure where it even applies nowadays (I didn't find any cases in a quick search but I might have missed some). 15px does seem to work a lot better with our button style though, as suggested by aerozol. Having the text as aria-label, title *and* alt for the image might be overkill, but there's no kill like overkill.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MBS-9704: 400 Bad Request error when requesting user-tags (or user-ratings) and user-collections
WS::2 'authenticate'is used to authenticate user from credentials and to check authorization scope.Calling it twice was calling
Catalyst 'authenticate'twice in a row which is not supposed to happen, thus returning 400 Bad Request error.This patch skips authenticating from credentials again if user already exists, that is, it has already been successfully authenticated from credentials.
WS::2 'authenticate'still checks authorization scope.