Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yrd: init at 0.5.3 #40166

Merged
merged 1 commit into from May 19, 2018
Merged

yrd: init at 0.5.3 #40166

merged 1 commit into from May 19, 2018

Conversation

akru
Copy link
Contributor

@akru akru commented May 8, 2018 •
edited

Motivation for this change

Added cjdns diagnostic tool.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

@GrahamcOfBorg eval

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: yrd

Partial log (click to expand)

writing entry points to yrd.egg-info/entry_points.txt
reading manifest file 'yrd.egg-info/SOURCES.txt'
writing manifest file 'yrd.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/sd4xwkx0v63dp60r915jd478y0ygziga-yrd-0.5.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: yrd

Partial log (click to expand)

writing entry points to yrd.egg-info/entry_points.txt
reading manifest file 'yrd.egg-info/SOURCES.txt'
writing manifest file 'yrd.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/d1jphwaxcllqg6p6zmrzy11n4cn4cdz1-yrd-0.5.3

nlewo
nlewo requested changes May 9, 2018
View reviewed changes
pkgs/tools/networking/yrd/default.nix Outdated
platforms = platforms.linux;

homepage = https://github.com/kpcyrd/yrd;
inherit version;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is common attribute of meta. Could you check and remove it?

pkgs/tools/networking/yrd/default.nix

propagatedBuildInputs = with pythonPackages; [ argh ];

meta = with stdenv.lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license is attribute is missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: yrd

Partial log (click to expand)

writing entry points to yrd.egg-info/entry_points.txt
reading manifest file 'yrd.egg-info/SOURCES.txt'
writing manifest file 'yrd.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/sd4xwkx0v63dp60r915jd478y0ygziga-yrd-0.5.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: yrd

Partial log (click to expand)

writing entry points to yrd.egg-info/entry_points.txt
reading manifest file 'yrd.egg-info/SOURCES.txt'
writing manifest file 'yrd.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/d1jphwaxcllqg6p6zmrzy11n4cn4cdz1-yrd-0.5.3

@nlewo
Copy link
Member

nlewo commented May 14, 2018

@akru Could you squash your commits?

@akru
Copy link
Contributor Author

akru commented May 14, 2018

@nlewo Yes, can I open another PR?

@nlewo
Copy link
Member

nlewo commented May 14, 2018 via email

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: yrd

Partial log (click to expand)

/nix/store/sd4xwkx0v63dp60r915jd478y0ygziga-yrd-0.5.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: yrd

Partial log (click to expand)

writing entry points to yrd.egg-info/entry_points.txt
reading manifest file 'yrd.egg-info/SOURCES.txt'
writing manifest file 'yrd.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/b9f13vcmgilsx8qyx7452mpd0dhgg8ps-yrd-0.5.3

@matthewbauer matthewbauer merged commit d1605c5 into NixOS:master May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akru @matthewbauer @GrahamcOfBorg @nlewo