Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kcgi: init -> 0.10.5 #40169

Merged
merged 1 commit into from May 20, 2018
Merged

kcgi: init -> 0.10.5 #40169

merged 1 commit into from May 20, 2018

Conversation

leenaars
Copy link
Contributor

@leenaars leenaars commented May 8, 2018

Motivation for this change

New fcgi library, also dependency for https://kristaps.bsd.lv/kcaldav/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

@GrahamcOfBorg eval

nativeBuildInputs = [ pkgconfig ];
buildInputs = [ ] ++ stdenv.lib.optionals stdenv.isLinux [ libbsd ] ;

configurePhase = "./configure";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessary. Please use dontAddPrefix instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unaware of that. Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants