gnucash: restore version 2.4 #40176
Merged
gnucash: restore version 2.4 #40176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How long do you intend on keeping this? |
|
Now that 18.09 is released, it's no longer needed. The 18.09 release notes includes upgrade instructions. Gnucash 2.6 should also no longer be needed. |
|
Thanks. Dropped in 370d08f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Pull request #39616 upgrades the default gnucash version from 2.4 to 3.1. Skipping major releases (in this case 2.6) is a problem for gnucash. See here.
This change restores gnucash 2.4 as the attribute
gnucash24, leaving 3.1 as the default. It doesn't solve the upgrade path problem, since getting gnucash 2.6 working is necessary to upgrade from 2.4 to 3.1. But users need to be given the chance to upgrade their data files before removing gnucash 2.4.Note:
2.4.nixis just a copy of the originaldefault.nix; Prior to 3.1 being added and becoming the default.Things done
build-use-sandboxinnix.confon non-NixOS)[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)[ ] Tested compilation of all pkgs that depend on this change usingnix-shell -p nox --run "nox-review wip"./result/bin/)