Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RDY] openntpd: make -s flag work #40171

Merged
merged 1 commit into from Jun 2, 2018
Merged

[RDY] openntpd: make -s flag work #40171

merged 1 commit into from Jun 2, 2018

Conversation

teto
Copy link
Member

@teto teto commented May 8, 2018

Motivation for this change

after seeing
adjtime failed: Invalid argument in my syslog, I tried using
ntpd -s but it would trigger
/etc/ntpd.conf: No such file or directory
see #31885

Things done

Instead of running the daemon with a specific config file, use the
standard file so that user are able to use the ntpd executable without
having to look for the current config file.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@teto
openntpd: make -s flag work
f5e169c 
after seeing
`adjtime failed: Invalid argument` in my syslog, I tried using
`ntpd -s` but it would trigger
`/etc/ntpd.conf: No such file or directory`
see NixOS#31885

Instead of running the daemon with a specific config file, use the
standard file so that user are able to use the ntp executable without
having to look for the current config file.
@teto teto changed the title openntpd: make -s flag work [RDY] openntpd: make -s flag work May 8, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: openntpd

Partial log (click to expand)

these paths will be fetched (0.05 MiB download, 0.23 MiB unpacked):
  /nix/store/hpxshyy5jninwpfkw0k1qkc0ddrnsp44-openntpd-6.2p3
copying path '/nix/store/hpxshyy5jninwpfkw0k1qkc0ddrnsp44-openntpd-6.2p3' from 'https://cache.nixos.org'...
/nix/store/hpxshyy5jninwpfkw0k1qkc0ddrnsp44-openntpd-6.2p3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: openntpd

Partial log (click to expand)

these paths will be fetched (0.78 MiB download, 2.62 MiB unpacked):
  /nix/store/lfvqk23iwdnq2m9fs3k35b0ayqnk6i5j-libressl-2.5.5
  /nix/store/n21hz32iff5fkph93lswy5442c05ziaq-openntpd-6.2p3
copying path '/nix/store/lfvqk23iwdnq2m9fs3k35b0ayqnk6i5j-libressl-2.5.5' from 'https://cache.nixos.org'...
copying path '/nix/store/n21hz32iff5fkph93lswy5442c05ziaq-openntpd-6.2p3' from 'https://cache.nixos.org'...
/nix/store/n21hz32iff5fkph93lswy5442c05ziaq-openntpd-6.2p3

@teto teto mentioned this pull request May 12, 2018
Open
@matthewbauer matthewbauer merged commit 20ca7af into NixOS:master Jun 2, 2018
@teto teto deleted the ntp branch June 2, 2018 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teto @GrahamcOfBorg @matthewbauer