Bug: initialize with {% @type %} #6077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
approved these changes
May 8, 2018
| @@ -4429,6 +4429,21 @@ describe "Semantic: instance var" do | |||
| ), inject_primitives: false) { types["Foo"] } | |||
| end | |||
|
|
|||
| it "is more permissive with macro def initialize, bug with named args" do | |||
There was a problem hiding this comment.
Reference this PR number in the spec name?
There was a problem hiding this comment.
That's a bit recursive :-)
I usually reference the issue number (bug), but there's none here (well, there's that comment...). In any case, the blame of that line will lead to this commit, and in GitHub it will relate to this PR.
There was a problem hiding this comment.
git blame can easilly be thrown off by a few refactors or file renames, far down the line.
| @@ -108,7 +108,7 @@ struct Crystal::TypeDeclarationProcessor | |||
| # removed if an explicit type is found (in remove_error). | |||
| @errors = {} of Type => Hash(String, Error) | |||
|
|
|||
| # Types that have a single macro def initialize | |||
| # Types whose initialize methods all are macro defs | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug found in #6063 (comment)
The compiler has a secret rule that's not documented (but probably should): if an
initializeuses@typein macros, then checking what instance variables are initialized is delayed until the semantic phase, only for those methods. This allows the definition ofinitializemethods that are based on a type's instance vars, for example.But there were a few bugs with that. This PR fixes those.