LB-354: Musicbrainz delete endpoint #409
Conversation
|
Rebase, please. |
paramsingh
force-pushed
the
musicbrainz-delete-endpoint
branch
from
75ee6f1
to
7366137
Compare
| try: | ||
| r.raise_for_status() | ||
| except HTTPError: | ||
| raise Unauthorized('Not authorized to use this view') |
There was a problem hiding this comment.
I like how you give no useful info the caller. Well done!
There was a problem hiding this comment.
https://httpstatuses.com/401 - Unauthorized requires a "WWW-Authenticate" header. Does this get set internally?
There was a problem hiding this comment.
Doesn't seem like werkzeug sets it (https://github.com/pallets/werkzeug/blob/master/werkzeug/exceptions.py#L214)
|
From the ticket, it seemed like the creation of the |
| @@ -120,6 +124,35 @@ def current_status(): | |||
| ) | |||
|
|
|||
|
|
|||
| @index_bp.route('/delete-user/<musicbrainz_id>') | |||
| def mb_user_deleter(musicbrainz_id): | |||
There was a problem hiding this comment.
We decided in last week's meeting that storing the editor IDs in LB et al. is the way to go, so MB will actually send the editor row ID here and not the name. (Not sure if you've already started updating it to expect that, or if musicbrainz_id is actually the user name here.)
|
|
||
|
|
||
| def _authorize_mb_user_deleter(auth_token): | ||
| query_url = 'https://musicbrainz.org/oauth2/userinfo' |
There was a problem hiding this comment.
(I mentioned this in the BookBrainz PR too, but) it'd be nice if the MusicBrainz server URL were configurable, so we don't have to hand-edit source files when testing this locally (or against test.mb, say). Not just here, but for OAuth logins and all other references too.
I just created the user we need manually and documented it here: https://github.com/metabrainz/syswiki/blob/master/MusicBrainzUserDeleter.md |
paramsingh
force-pushed
the
musicbrainz-delete-endpoint
branch
from
7366137
to
f2934f6
Compare
paramsingh
force-pushed
the
musicbrainz-delete-endpoint
branch
from
f2934f6
to
9be28ed
Compare
|
This should be ready for review again, I've rebased, updated it to expect MusicBrainz Row IDs and added more tests. |
|
OK, I think this is ready to merge. |
|
Is this working? I deleted my MEB account ages ago yet my LB profile is still present... |
This PR adds the MusicBrainz
delete-userendpoint as specified by https://tickets.metabrainz.org/browse/MBS-9680.