Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: haskellPackages: Fix overriding all-cabal-hashes #40561

Merged
merged 1 commit into from May 16, 2018
Merged

backport: haskellPackages: Fix overriding all-cabal-hashes #40561

merged 1 commit into from May 16, 2018

Conversation

ElvishJerricco
Copy link
Contributor

@ElvishJerricco ElvishJerricco commented May 15, 2018 •
edited

Motivation for this change

Just a nice little feature that doesn't work as intended on 18.03 currently. EDIT: See #37825

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ElvishJerricco ElvishJerricco requested a review from peti as a code owner May 15, 2018 18:30
@ElvishJerricco ElvishJerricco changed the title haskellPackages: Fix overriding all-cabal-hashes backport: haskellPackages: Fix overriding all-cabal-hashes May 15, 2018
@matthewbauer matthewbauer merged commit 56f199b into NixOS:release-18.03 May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti peti is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ElvishJerricco @matthewbauer @GrahamcOfBorg