Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: Fix build and setup hook #40566

Merged
merged 1 commit into from May 15, 2018
Merged

cmake: Fix build and setup hook #40566

merged 1 commit into from May 15, 2018

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented May 15, 2018 •
edited

Motivation for this change

I screwed this up in 330ca73 / #40529. I'm sorry.

Things done

Testing building Darwin stdenv (includes CMake).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314
cmake: Fix build and setup hook
0ff650a 
I screwed this up in 330ca73. I'm
sorry.
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cmake

Partial log (click to expand)

shrinking /nix/store/c4pcj6xcsy9f0f100pyyirg0a3azavp0-cmake-3.10.2/bin/cpack
shrinking /nix/store/c4pcj6xcsy9f0f100pyyirg0a3azavp0-cmake-3.10.2/bin/cmake
shrinking /nix/store/c4pcj6xcsy9f0f100pyyirg0a3azavp0-cmake-3.10.2/bin/ctest
strip is /nix/store/mgyvr3kil9qv0mywikpi0dbli061bpg4-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/c4pcj6xcsy9f0f100pyyirg0a3azavp0-cmake-3.10.2/bin
patching script interpreter paths in /nix/store/c4pcj6xcsy9f0f100pyyirg0a3azavp0-cmake-3.10.2
/nix/store/c4pcj6xcsy9f0f100pyyirg0a3azavp0-cmake-3.10.2/share/cmake-3.10/Modules/CPack.STGZ_Header.sh.in: interpreter directive changed from "/bin/sh" to "/nix/store/3r4wp5drzynkz6hccmjpifkzwgqbs5nb-bash-4.4-p19/bin/sh"
/nix/store/c4pcj6xcsy9f0f100pyyirg0a3azavp0-cmake-3.10.2/share/cmake-3.10/Modules/Squish4RunTestCase.sh: interpreter directive changed from "/bin/sh" to "/nix/store/3r4wp5drzynkz6hccmjpifkzwgqbs5nb-bash-4.4-p19/bin/sh"
/nix/store/c4pcj6xcsy9f0f100pyyirg0a3azavp0-cmake-3.10.2/share/cmake-3.10/Modules/SquishRunTestCase.sh: interpreter directive changed from "/bin/sh" to "/nix/store/3r4wp5drzynkz6hccmjpifkzwgqbs5nb-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/c4pcj6xcsy9f0f100pyyirg0a3azavp0-cmake-3.10.2...

@Ericson2314
Copy link
Member Author

Build Darwin stdenv.

@Ericson2314 Ericson2314 merged commit ce018be into NixOS:staging May 15, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cmake

Partial log (click to expand)

shrinking /nix/store/hvcgwlr2750q84y61cg5xxvnia00fzdg-cmake-3.10.2/bin/cpack
shrinking /nix/store/hvcgwlr2750q84y61cg5xxvnia00fzdg-cmake-3.10.2/bin/ctest
shrinking /nix/store/hvcgwlr2750q84y61cg5xxvnia00fzdg-cmake-3.10.2/bin/cmake
strip is /nix/store/k4w0i2ja8g2xxgx46i8h5m4bzcf6g9pj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hvcgwlr2750q84y61cg5xxvnia00fzdg-cmake-3.10.2/bin
patching script interpreter paths in /nix/store/hvcgwlr2750q84y61cg5xxvnia00fzdg-cmake-3.10.2
/nix/store/hvcgwlr2750q84y61cg5xxvnia00fzdg-cmake-3.10.2/share/cmake-3.10/Modules/CPack.STGZ_Header.sh.in: interpreter directive changed from "/bin/sh" to "/nix/store/sqwh83zs10jg65a15dbb6lg720rb85yw-bash-4.4-p19/bin/sh"
/nix/store/hvcgwlr2750q84y61cg5xxvnia00fzdg-cmake-3.10.2/share/cmake-3.10/Modules/Squish4RunTestCase.sh: interpreter directive changed from "/bin/sh" to "/nix/store/sqwh83zs10jg65a15dbb6lg720rb85yw-bash-4.4-p19/bin/sh"
/nix/store/hvcgwlr2750q84y61cg5xxvnia00fzdg-cmake-3.10.2/share/cmake-3.10/Modules/SquishRunTestCase.sh: interpreter directive changed from "/bin/sh" to "/nix/store/sqwh83zs10jg65a15dbb6lg720rb85yw-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/hvcgwlr2750q84y61cg5xxvnia00fzdg-cmake-3.10.2...

@matthewbauer
Copy link
Member

Can you cancel the jobs running on Hydra staging? That should speed this up a little bit.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: cmake

Partial log (click to expand)

cannot build derivation '/nix/store/4z5qw8dz05i9hj833gcklp0mvb214pzk-apple-framework-ServiceManagement.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/xi53swyhm6piliz5zvcrlkymzjq1j4rg-apple-framework-SystemConfiguration.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/0yqbn4hfws3dpm178zlxq84kvr2mfyhg-apple-framework-CoreGraphics.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/wv33vaq2wb7y53x5nm01am6463igcnh3-apple-framework-CoreServices.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/8lmza26rr90knxn1xwd0k29bd5im4vqh-apple-framework-CoreText.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/gsrgdk9nq1qmq4dga7fgwwkpwn21131m-apple-framework-ImageIO.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/pjn80v3fvyplsw3g24yin82m6m9chy5q-apple-framework-ApplicationServices.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/04avdz183avhgg2awh54slcr7b8zsajw-libuv-1.20.2.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/4v5whqyi0pygwanv0v160smf832zdv5d-cmake-3.10.2.drv': 14 dependencies couldn't be built
error: build of '/nix/store/4v5whqyi0pygwanv0v160smf832zdv5d-cmake-3.10.2.drv' failed

@Ericson2314
Copy link
Member Author

@matthewbauer which/how? If I cancel and old staging job won't it also cancel new staging builds that happened to be the same (e.g. Linux ones)? Conversely, all the mac ones should have failed? Hopefully CMake failed on all platforms so there's no queued builds involving the old version.

Ericson2314 referenced this pull request May 15, 2018
@Ericson2314
treewide: Get rid of all uses of crossConfig
330ca73 
The hack of using `crossConfig` to enforce stricter handling of
dependencies is replaced with a dedicated `strictDeps` for that purpose.
(Experience has shown that my punning was a terrible idea that made more
difficult and embarrising to teach teach.)

Now that is is clear, a few packages now use `strictDeps`, to fix
various bugs:

 - bintools-wrapper and cc-wrapper
@Ericson2314 Ericson2314 deleted the strictDeps-for-18.03 branch June 18, 2018 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @GrahamcOfBorg @matthewbauer