Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polybar: make call to i3 pure #39653

Merged
merged 1 commit into from May 12, 2018
Merged

Polybar: make call to i3 pure #39653

merged 1 commit into from May 12, 2018

Conversation

ayyess
Copy link
Contributor

@ayyess ayyess commented Apr 28, 2018

Motivation for this change

As noted in nix-community/home-manager#206 (comment), "polybar uses i3ipc to communicate with i3. Error appears since i3ipc::get_socketpath simply calls i3 executable to get the socket path."

This PR makes the call to i3 pure.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

Could you make this a wrapper instead? Patches usually require more maintanence.

@matthewbauer matthewbauer merged commit 29c2c64 into NixOS:master May 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ayyess @matthewbauer @GrahamcOfBorg