Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max KSP version should not be "any" in the UI #2434

Closed
linuxgurugamer opened this issue Apr 28, 2018 · 3 comments
Closed

Max KSP version should not be "any" in the UI #2434

linuxgurugamer opened this issue Apr 28, 2018 · 3 comments
Labels
Needs more info We need more info

Comments

@linuxgurugamer
Copy link
Contributor

I brought this up before.

Based on what I just saw in the program, the logic may wrong, and should be:

If there is ONLY a KSP_VERSION, then the min version and max version are the same as the KSP_VERSION
If there is either a KSP_MIN_VERSION or a KSP_MAX_VERSION specified, then the following applies:
If there is only a MIN version, then the max version should be any
@DasSkelett
Copy link
Member 

public KspVersion LatestCompatibleKSP()
{
    // Find the highest compatible KSP version
    if (ksp_version_max != null)
        return ksp_version_max;
    else if (ksp_version != null)
        return ksp_version;
    else
        // No upper limit.
        return KspVersion.Any;
}

As I read this code, it does exactly that.

@HebaruSan
Copy link
Member

Yeah, as far as I know that's exactly what it does.
@linuxgurugamer, can you please elaborate on the problem you saw?

Sorry, something went wrong.

@HebaruSan HebaruSan added the Needs more info We need more info label Apr 28, 2018
@HebaruSan
Copy link
Member

Appears to be a non-issue, clarification not received. Closing for now.

@linuxgurugamer, if you are able to give more information about this, please do so and we can re-open it for investigation.

Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs more info We need more info
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HebaruSan @linuxgurugamer @DasSkelett