Skip to content

Commit

Permalink
Fix an issue in output of invalid hex.
Browse files Browse the repository at this point in the history
Exclude weird syntax tests after evaluating them.  Not important enough to fix atm.
  • Loading branch information
enebo committed Apr 27, 2018
1 parent c4a4a10 commit 1bf8e9d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
2 changes: 1 addition & 1 deletion core/src/main/java/org/jruby/lexer/yacc/RubyLexer.java
Expand Up @@ -2342,7 +2342,7 @@ public int readEscape() throws IOException {
pushback(c);
return scanOct(3);
case 'x' : // hex constant
return scanHex(2, false, "Invalid escape character syntax");
return scanHex(2, false, "Invalid hex escape");
case 'b' : // backspace
return '\010';
case 's' : // space
Expand Down
7 changes: 7 additions & 0 deletions test/mri/excludes/TestParse.rb
@@ -1,10 +1,17 @@
exclude :test_arg_concat, "needs investigation"
exclude :test_error_def_in_argument, "provides different syntax errors"
exclude :test_invalid_char, "needs investigation"
exclude :test_lparenarg, "space issue with parens in really weird syntax"
exclude :test_method_block_location, "needs investigation"
exclude :test_method_location_in_rescue, "parser updates corrected defs to use first line"
exclude :test_named_capture_conflict, "needs investigation"
exclude :test_negative_line_number, "only backtrace is wrong from linenum instr getting wrong number"
exclude :test_question, "needs investigation"
exclude :test_rescue_in_command_assignment, "needs investigation"
exclude :test_string, "lots of very specific error messages in which we differ a little"
exclude :test_symbol, "we should allow empty unicode escapes that not really"
exclude :test_truncated_source_line, "2.5 truncates long source lines...we dont yet"
exclude :test_unexpected_token_after_numeric, "More strict parsing of text immediately after numbers"
exclude :test_unused_variable, "missing warning in parser (#2147)"
exclude :test_void_expr_stmts_value, "1; next; 2 is figured via compile.c. IR can do equivalent for 9k. Not a huge issue for 1.7.x barring real issue"
exclude :test_yyerror_at_eol, "needs investigation"

0 comments on commit 1bf8e9d

Please sign in to comment.