Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: delete no longer needed patchset #39628

Closed
wants to merge 1 commit into from
Closed

chromium: delete no longer needed patchset #39628

wants to merge 1 commit into from

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Apr 27, 2018 •
edited

If I read this error message correctly, this patchset is no longer
needed:

trace: WARNING: chromium: stable version 66.0.3359.117 is newer than a patchset bounded at 66. You can safely delete it.

Building before and after this change on my (non-aarch64) machine doesn't change the hash, so I can't do much for testing except wait for ofborg's build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ekleog
chromium: delete no longer needed patchset
bb2c5a2 
If I read this error message correctly, this patchset is no longer
needed:

trace: WARNING: chromium: stable version 66.0.3359.117 is newer than a patchset bounded at 66. You can safely delete it.
@Mic92
Copy link
Member

Mic92 commented Apr 27, 2018

Ofborg will timeout for sure for chromium.

@Ekleog
Copy link
Member Author

Ekleog commented Apr 27, 2018

Cc @chaoflow @bendlas

@Ekleog
Copy link
Member Author

Ekleog commented Apr 27, 2018

Well, I'm not sure it will, as it's supposed to not rebuild anything, it should get it from binary cache :)

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: chromium

Partial log (click to expand)

copying path '/nix/store/24g1y08jg7w9di4464n6jg4nk1jlg8i5-xf86miscproto-0.9.3' from 'https://cache.nixos.org'...
copying path '/nix/store/34x5d2gychq993nqlfwbi2sb9b34d6m2-xkeyboard-config-2.22' from 'https://cache.nixos.org'...
copying path '/nix/store/hg065lpjnr75md99mg43vly8gqldwq0w-libXxf86misc-1.0.3' from 'https://cache.nixos.org'...
copying path '/nix/store/72w4gn2py09xd648xcq3m82kbafiapnk-xset-1.2.3' from 'https://cache.nixos.org'...
copying path '/nix/store/kfc2i1ilw45jwnzb3vn79w15m8yly0xw-xdg-utils-1.1.2' from 'https://cache.nixos.org'...
copying path '/nix/store/p4kl7hbyiz677583dnps47pxrc25sp51-libxkbcommon-0.8.0' from 'https://cache.nixos.org'...
copying path '/nix/store/c8i4flxb5qc31v6zi1jpmd7512amyms8-gtk+3-3.22.29' from 'https://cache.nixos.org'...
copying path '/nix/store/3rsbdgsndcww95h4hvyfy3vjsrm8hfzz-chromium-66.0.3359.117' from 'https://cache.nixos.org'...
copying path '/nix/store/z3yj08fj0w4kw2qmgy52mbfp5s6mvcba-chromium-66.0.3359.117' from 'https://cache.nixos.org'...
/nix/store/z3yj08fj0w4kw2qmgy52mbfp5s6mvcba-chromium-66.0.3359.117

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: chromium

Partial log (click to expand)

[4494/32000] CXX obj/skia/skia_core_and_effects/GrCircleBlurFragmentProcessor.o
[4495/32000] CXX obj/skia/skia_core_and_effects/SkImage_Raster.o
[4496/32000] CXX obj/skia/skia_core_and_effects/SkOpSegment.o
[4497/32000] CXX obj/skia/skia_core_and_effects/SkArithmeticImageFilter.o
[4498/32000] CXX obj/skia/skia_core_and_effects/SkBlurMaskFilter.o
[4499/32000] CXX obj/skia/skia_core_and_effects/SkPathOpsTSect.o
ninja: build stopped: subcommand failed.
builder for '/nix/store/cf62nixdfh6i1hbaqg91ziqrm2xfcgi6-chromium-66.0.3359.117.drv' failed with exit code 1
cannot build derivation '/nix/store/rcsgrj2b21309f75szsmax7d27s7497n-chromium-66.0.3359.117.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/rcsgrj2b21309f75szsmax7d27s7497n-chromium-66.0.3359.117.drv' failed

Ekleog added a commit to Ekleog/nixpkgs that referenced this pull request Apr 27, 2018
@Ekleog
chromium: skia patch appears to be still needed with 66 on aarch64
862af91 
Cc @chaoflow @bendlas
Replaces NixOS#39628
@Ekleog Ekleog mentioned this pull request Apr 27, 2018
Merged
8 tasks
@Ekleog
Copy link
Member Author

Ekleog commented Apr 27, 2018

Sounds like the patch was actually still required. Closing in favor of #39633.

@Ekleog Ekleog closed this Apr 27, 2018
dezgeg pushed a commit that referenced this pull request Apr 29, 2018
@Ekleog @dezgeg
chromium: skia patch appears to be still needed with 66 on aarch64
a07881c 
Cc @chaoflow @bendlas
Replaces #39628
Synthetica9 pushed a commit to Synthetica9/nixpkgs that referenced this pull request May 3, 2018
@Ekleog @Synthetica9
chromium: skia patch appears to be still needed with 66 on aarch64
7f9e7d4 
Cc @chaoflow @bendlas
Replaces NixOS#39628
globin pushed a commit to mayflower/nixpkgs that referenced this pull request May 24, 2018
@Ekleog @globin
chromium: skia patch appears to be still needed with 66 on aarch64
a97796a 
Cc @chaoflow @bendlas
Replaces NixOS#39628

(cherry picked from commit a07881c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ekleog @Mic92 @GrahamcOfBorg