Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCE: pull the ssh host keys from the metadata service as expected by NixOps. #39654

Merged
merged 3 commits into from May 3, 2018
Merged

GCE: pull the ssh host keys from the metadata service as expected by NixOps. #39654

merged 3 commits into from May 3, 2018

Conversation

AmineChikhaoui
Copy link
Member

Issues: #38623 NixOS/nixops#930.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@AmineChikhaoui
Copy link
Member Author

attn @rbvermaa

@rbvermaa rbvermaa merged commit 41512bf into NixOS:master May 3, 2018
@YorikSar
Copy link
Contributor

YorikSar commented May 9, 2018

Why did you make it fail if there is no SSH host keys in metadata (which is a normal situation for normal users)? Is there no other way to make it work with nixops, only hardcoded host SSH key?

jbboehr added a commit to BitKitchen/nixpkgs-channels that referenced this pull request May 11, 2018
@jbboehr
Try pulling in NixOS/nixpkgs#39654 instead
453a88d
@jbboehr jbboehr mentioned this pull request May 14, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AmineChikhaoui @YorikSar @bjornfor @rbvermaa @GrahamcOfBorg