Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix refinements #5153

Closed
headius opened this issue Apr 27, 2018 · 2 comments
Closed

Fix refinements #5153

headius opened this issue Apr 27, 2018 · 2 comments
Milestone
JRuby 9.2.7.0

Comments

@headius
Copy link
Member

headius commented Apr 27, 2018 •
edited
Loading

This is a catch-all bug for the various refinements issues. I'll try to get as close to 100% as possible before 9.2.

Known bugs fixed for this issue: #5054 #5221 #4514 #4489 #4330 #4288 #4237 #4236.
@headius headius added this to the JRuby 9.2.0.0 milestone Apr 27, 2018
headius added a commit that referenced this issue Apr 27, 2018
@headius
Allow modules to be refined. Fixes #4288.
1839880 
See #5153.

This also includes some re-ports of MRI code along the refine and
using paths. All tests in MRI test_refinement.rb now run to
completion, with 29 F/E.
headius added a commit that referenced this issue Apr 28, 2018
@headius
Enable refinements in subsequent evals if active in scope. #5153
021f497
headius added a commit that referenced this issue Apr 28, 2018
@headius
Disallow refinement modules in include and prepend. #5153
0568106
@enebo enebo modified the milestones: JRuby 9.2.0.0, JRuby 9.2.1.0 May 24, 2018
@headius headius modified the milestones: JRuby 9.2.1.0, JRuby 9.2.2.0 Oct 26, 2018
@enebo enebo modified the milestones: JRuby 9.2.5.0, JRuby 9.2.6.0 Dec 6, 2018
@enebo enebo modified the milestones: JRuby 9.2.6.0, JRuby 9.2.7.0 Dec 19, 2018
This was referenced Dec 21, 2018
Closed
Closed
@Envek
Copy link

Envek commented Jan 4, 2019

Please also add #5221 to this list 🙏

@enebo enebo modified the milestones: JRuby 9.2.7.0, JRuby 9.2.6.0 Jan 9, 2019
@enebo enebo modified the milestones: JRuby 9.2.6.0, JRuby 9.2.7.0 Feb 11, 2019
@headius
Copy link
Member Author

headius commented Apr 8, 2019

@Envek It appears #5221 was fixed along with most of the others.

Only #4840 remains unsolved, and we know the issue. I'm going to mark this one fixed since the bulk of user-reported refinement problems are now solved.

@headius headius closed this as completed Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.2.7.0
Development

No branches or pull requests
3 participants
@headius @enebo @Envek