Improve WebSocket handshake validation (fixed) #6027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
approved these changes
Apr 29, 2018
|
@RX14 Any idea about the broken pipe error in the specs? I can't reproduce it locally. |
|
It's a linux thing so you'll have to reproduce it on linux |
|
I know 😁 It seems the error doesn't reproduce when this spec is run alone. And it looks very much similar to the error in #5958, probably related to |
|
It is indeed the same as the error discovered in #5958. For some reason on Linux there seems to be some strange behaviour when |
sdogruyol
approved these changes
May 1, 2018
asterite
approved these changes
May 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #5327 to the changes to HTTP::Server API from #5776