Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-17.09] slurm: Fix CVE-2018-7033 #39667

Merged
merged 1 commit into from Apr 30, 2018
Merged

[release-17.09] slurm: Fix CVE-2018-7033 #39667

merged 1 commit into from Apr 30, 2018

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Apr 29, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: slurm

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: slurm

Partial log (click to expand)

patching sources
applying patch /nix/store/05mx50jy7wds16y2wf3c2w3zfvqpkb5m-CVE-2018-7033.patch
patching file NEWS
Hunk #1 FAILED at 32.
1 out of 1 hunk FAILED -- saving rejects to file NEWS.rej
patching file src/common/pack.c
patching file src/common/pack.h
patching file src/common/slurm_xlator.h
builder for '/nix/store/j1a0xhjg3g4b8ycmaq51v7ppkyjf7jss-slurm-17.02.9.drv' failed with exit code 1
error: build of '/nix/store/j1a0xhjg3g4b8ycmaq51v7ppkyjf7jss-slurm-17.02.9.drv' failed

@veprbl veprbl force-pushed the pr/release-17.09/CVE-2018-7033 branch from 49697df to 1daa405 Compare April 29, 2018 04:46
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: slurm

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: slurm

Partial log (click to expand)

shrinking /nix/store/j9xqaa6qqdxy83n08kvlhajgxgvlkykl-slurm-17.02.9/sbin/slurmstepd
shrinking /nix/store/j9xqaa6qqdxy83n08kvlhajgxgvlkykl-slurm-17.02.9/sbin/slurmdbd
gzipping man pages under /nix/store/j9xqaa6qqdxy83n08kvlhajgxgvlkykl-slurm-17.02.9/share/man/
stripping (with flags -S) in /nix/store/j9xqaa6qqdxy83n08kvlhajgxgvlkykl-slurm-17.02.9/lib  /nix/store/j9xqaa6qqdxy83n08kvlhajgxgvlkykl-slurm-17.02.9/bin  /nix/store/j9xqaa6qqdxy83n08kvlhajgxgvlkykl-slurm-17.02.9/sbin
patching script interpreter paths in /nix/store/j9xqaa6qqdxy83n08kvlhajgxgvlkykl-slurm-17.02.9
checking for references to /build in /nix/store/j9xqaa6qqdxy83n08kvlhajgxgvlkykl-slurm-17.02.9...
moving /nix/store/j9xqaa6qqdxy83n08kvlhajgxgvlkykl-slurm-17.02.9/sbin/* to /nix/store/j9xqaa6qqdxy83n08kvlhajgxgvlkykl-slurm-17.02.9/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/2x8w49gqrjhjrj9splaw265szyvpzhd5-slurm-17.02.9-dev
patching script interpreter paths in /nix/store/2x8w49gqrjhjrj9splaw265szyvpzhd5-slurm-17.02.9-dev
checking for references to /build in /nix/store/2x8w49gqrjhjrj9splaw265szyvpzhd5-slurm-17.02.9-dev...

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: slurm

Partial log (click to expand)

patching sources
applying patch /nix/store/05mx50jy7wds16y2wf3c2w3zfvqpkb5m-CVE-2018-7033.patch
patching file NEWS
Hunk #1 FAILED at 32.
1 out of 1 hunk FAILED -- saving rejects to file NEWS.rej
patching file src/common/pack.c
patching file src/common/pack.h
patching file src/common/slurm_xlator.h
builder for '/nix/store/kjgvmvcw901wzzglhfdbn91z2q5fwsz7-slurm-17.02.9.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/kjgvmvcw901wzzglhfdbn91z2q5fwsz7-slurm-17.02.9.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: slurm

Partial log (click to expand)

shrinking /nix/store/bniaw44xcfgsk3n18gjj74zf1d6d4rp4-slurm-17.02.9/lib/libslurm.so.31.0.0
gzipping man pages under /nix/store/bniaw44xcfgsk3n18gjj74zf1d6d4rp4-slurm-17.02.9/share/man/
stripping (with flags -S) in /nix/store/bniaw44xcfgsk3n18gjj74zf1d6d4rp4-slurm-17.02.9/lib  /nix/store/bniaw44xcfgsk3n18gjj74zf1d6d4rp4-slurm-17.02.9/bin  /nix/store/bniaw44xcfgsk3n18gjj74zf1d6d4rp4-slurm-17.02.9/sbin
patching script interpreter paths in /nix/store/bniaw44xcfgsk3n18gjj74zf1d6d4rp4-slurm-17.02.9
checking for references to /build in /nix/store/bniaw44xcfgsk3n18gjj74zf1d6d4rp4-slurm-17.02.9...
moving /nix/store/bniaw44xcfgsk3n18gjj74zf1d6d4rp4-slurm-17.02.9/sbin/* to /nix/store/bniaw44xcfgsk3n18gjj74zf1d6d4rp4-slurm-17.02.9/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/62mrdlwbgw8a40yn6i97ifc4wh1qj569-slurm-17.02.9-dev
patching script interpreter paths in /nix/store/62mrdlwbgw8a40yn6i97ifc4wh1qj569-slurm-17.02.9-dev
checking for references to /build in /nix/store/62mrdlwbgw8a40yn6i97ifc4wh1qj569-slurm-17.02.9-dev...
/nix/store/bniaw44xcfgsk3n18gjj74zf1d6d4rp4-slurm-17.02.9

@xeji
Copy link
Contributor

xeji commented Apr 30, 2018

No point in bumping the version for 17.09, so let's just merge the patch.

@xeji xeji merged commit 68fe8c9 into NixOS:release-17.09 Apr 30, 2018
@veprbl veprbl deleted the pr/release-17.09/CVE-2018-7033 branch December 1, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @GrahamcOfBorg @xeji