Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rounded-mgenplus: init at 20150602 #39659

Merged
merged 2 commits into from May 12, 2018
Merged

rounded-mgenplus: init at 20150602 #39659

merged 2 commits into from May 12, 2018

Conversation

mnacamura
Copy link
Contributor

Motivation for this change

This is a rounded Japanese font which supports plenty of Kanji characters and has many type face variations.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

xeji
xeji reviewed May 12, 2018
View reviewed changes
pkgs/data/fonts/rounded-mgenplus/default.nix Outdated

let
pname = "rounded-mgenplus";
version = "2015-06-02";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also call the version "20150602" here and get rid of the replaceStrings below. Both date formats are acceptable and used by many packages. Your choice.

pkgs/data/fonts/rounded-mgenplus/default.nix Outdated
homepage = http://jikasei.me/font/rounded-mgenplus/;
license = licenses.ofl;
platforms = platforms.all;
maintainers = with maintainers; [ ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to be a maintainer of this package? If yes, please add yourself to maintainers/maintainer-list.nix and to this list.

@mnacamura mnacamura changed the title rounded-mgenplus: init at 2015-06-02 rounded-mgenplus: init at 20150602 May 12, 2018
@xeji
Copy link
Contributor

xeji commented May 12, 2018

@GrahamcOfBorg build rounded-mgenplus

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: rounded-mgenplus

Partial log (click to expand)

Blocks = 1

Everything is Ok

Folders: 1
Files: 77
Size:       702233529
Compressed: 55829761
installing
/nix/store/laf9hjl6l6l8xbrk3anawcbcwaajwl60-rounded-mgenplus-20150602

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rounded-mgenplus

Partial log (click to expand)

Blocks = 1

Everything is Ok

Folders: 1
Files: 77
Size:       702233529
Compressed: 55829761
installing
/nix/store/a2r0zihjnsc2bjw9ik3djk42ygmkfwq5-rounded-mgenplus-20150602

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: rounded-mgenplus

Partial log (click to expand)

Blocks = 1

Everything is Ok

Folders: 1
Files: 77
Size:       702233529
Compressed: 55829761
installing
/nix/store/0izjan39cic52yw1pvc4pffjrpck3yf3-rounded-mgenplus-20150602

@xeji
Copy link
Contributor

xeji commented May 12, 2018

Thank you!

@xeji xeji merged commit 9e6d50b into NixOS:master May 12, 2018
@mnacamura mnacamura deleted the rounded-mgenplus branch May 12, 2018 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mnacamura @xeji @GrahamcOfBorg