Skip to content
This repository was archived by the owner on Apr 12, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a67a7e41dcfb
Choose a base ref
...
head repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5965316f7488
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Apr 28, 2018

  1. nixos/tests/chromium: Wait 10s after new window 

    This is a very very very ugly workaround and it's because Chromium seems
to eat keystroke for a few seconds after a new window is created.

I haven't found a better solution yet, so let's at least unbreak the
test until we come up with a better way.

Thanks to @vcunat for bringing this to my attention and also doing the
initial bisect.

The change that brought up this problem was 2b29e40,
which updated Chromium from version 65.0.3325.181 to version
66.0.3359.117. Unfortunately the upstream changelog[1] is way too large
to actually guess what the breaking change is.

[1]: https://chromium.googlesource.com/chromium/src/+log/65.0.3325.181..66.0.3359.117?pretty=fuller&n=10000

Signed-off-by: aszlig <aszlig@nix.build>
Cc: @bendlas, @vcunat
(cherry picked from commit 1b1b76f)
    @aszlig @vcunat
    aszlig authored and vcunat committed Apr 28, 2018
    Copy the full SHA
    5965316 View commit details
Showing with 5 additions and 0 deletions.
  1. +5 −0 nixos/tests/chromium.nix
5 changes: 5 additions & 0 deletions nixos/tests/chromium.nix
View file
Original file line number Diff line number Diff line change
@@ -94,6 +94,11 @@ mapAttrs (channel: chromiumPkg: makeTest rec {
''}");
if ($status == 0) {
$ret = 1;
# XXX: Somehow Chromium is not accepting keystrokes for a few
# seconds after a new window has appeared, so let's wait a while.
$machine->sleep(10);
last;
}
$machine->sleep(1);