Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makemkv: 1.10.8 -> 1.12.2, switch from qt4 to qt5 #39652

Merged
merged 1 commit into from Apr 29, 2018

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Apr 28, 2018

Motivation for this change

The old version didn't build anymore, because it failed to download from their site.

The move the qt5 is motivated by #33248.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

It fails to detect drives without the sg module loaded, not sure how to work around this (except for manually loading it) or if this was already the case with the previous release, as I couldn't build that.

@xeji xeji merged commit 1c380fd into NixOS:master Apr 29, 2018
@ajs124 ajs124 deleted the makemkv_1_12_qt5 branch April 30, 2018 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants